From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mgiu8-0006pt-JN
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 13:36:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mgiu3-0006oT-CE
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 13:36:55 -0400
Received: from [199.232.76.173] (port=33661 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mgiu3-0006oQ-6N
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 13:36:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53440)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1Mgiu2-0003R3-N2
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 13:36:51 -0400
Date: Thu, 27 Aug 2009 14:36:45 -0300
From: Glauber Costa <glommer@redhat.com>
Message-ID: <20090827173645.GB5746@mothafucka.localdomain>
References: <1251291946-25821-1-git-send-email-glommer@redhat.com>
	<1251291946-25821-2-git-send-email-glommer@redhat.com>
	<1251291946-25821-3-git-send-email-glommer@redhat.com>
	<1251291946-25821-4-git-send-email-glommer@redhat.com>
	<1251291946-25821-5-git-send-email-glommer@redhat.com>
	<1251291946-25821-6-git-send-email-glommer@redhat.com>
	<m3y6p6ciif.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3y6p6ciif.fsf@neno.mitica>
Subject: [Qemu-devel] Re: [PATCH 05/12] fix broken migration
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@trasno.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, Aug 27, 2009 at 12:33:44AM +0200, Juan Quintela wrote:
> Glauber Costa <glommer@redhat.com> wrote:
> > While fixing migration with -S, commit
> > 89befdd1a6b18215153b8976682d57b7d03d5782 broke the rest of us. Poor
> > glommer, with a poor family, spare him his life from this monstruosity.
> >
> > Since the unconditional vm_start, not autostart was the villain, I'm putting
> > back autostart. Let me know if you prefer other solutions, it doesn't really matter,
> > doesn't really matter to me.
> >
> > Any way the wind blows...
> 
> Please drop this one.  I agree with bonzini here.
> It breaks completely incoming migration, and conflicts with semantics of
> next one.
wrong semantics is not a problem here, as long as we keep the same semantics.

For master, I can agree that the work you've done leave us at a better shape, but
for stable-0.10, this patch is totally needed for migration to work.