All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Georgi Chorbadzhiyski <gf@unixsol.org>
Cc: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: Add support for Rotronic silver/white handset in cm109 driver
Date: Mon, 31 Aug 2009 18:37:38 -0700	[thread overview]
Message-ID: <20090901021017.26A96526EA5@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <4A9ACD69.5030501@unixsol.org>

Hi Georgi,

On Sun, Aug 30, 2009 at 10:05:13PM +0300, Georgi Chorbadzhiyski wrote:
> The following patch adds support for yet another keymap in
> cm109 driver. Rotronic silver/white is USB "Skype" handset
> sold in Bulgaria and Serbia (according to Google). With this
> cheap stuff a picture is the only way to identify what you've
> got, so here is one:
>    http://www.reset.bg/catalog/images/skyphoneusbbelihcek.jpg
> 

While there is nothing wrong with the patch I am hesitant to apply it.
Any chance we could push it onto HAL or maybe have your application to
load appropriate keymap? I know we can't do it automatically because
vendor and product IDs are the same for all these devices... It's just
putting every keymap into the kernel is not sustainable.

-- 
Dmitry

  reply	other threads:[~2009-09-01  1:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-30 19:05 [PATCH] input: Add support for Rotronic silver/white handset in cm109 driver Georgi Chorbadzhiyski
2009-08-30 19:05 ` Georgi Chorbadzhiyski
2009-09-01  1:37 ` Dmitry Torokhov [this message]
2009-09-01  8:32   ` Georgi Chorbadzhiyski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090901021017.26A96526EA5@mailhub.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=daniel@gimpelevich.san-francisco.ca.us \
    --cc=gf@unixsol.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.