All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Michael Krufky <mkrufky@kernellabs.com>
Cc: linux-media <linux-media@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PULL] http://kernellabs.com/hg/~mkrufky/sms1xxx
Date: Tue, 1 Sep 2009 10:47:31 -0300	[thread overview]
Message-ID: <20090901104731.5f119d53@pedra.chehab.org> (raw)
In-Reply-To: <303a8ee30908310403x73d067rd58d01fbd4fde299@mail.gmail.com>

Em Mon, 31 Aug 2009 07:03:18 -0400
Michael Krufky <mkrufky@kernellabs.com> escreveu:

> I see the GPIO fix in your git tree now -- Thanks for merging it.
> 
> However, I also see this changeset:
> 
> http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-2.6.git;a=commitdiff;h=31e0ad693fb4e1d1be19dbe1c4f5a1ab9978e810
> 
> I believe that it is way too late in 2.6.31 to merge a changeset like
> this -- Please revert that and if there is actually a Kconfig change
> required, merge a more minimal change for 2.6.31 and hold off this
> huge, risky change for the next merge window.
> 
> There is not enough time to fix this, if this changeset causes
> additional breakage.

This is just Kbuild changes, and it is there at linux-next for some time,
where for sure people already tried to do several different building tests.
Among some cosmetics, it removes a dead symbol (DVB_SIANO_SMS1XXX_SMS_IDS).

It is very bad to expose to the user a config option that configs nothing.

Anyway, Linus already merged the pull request. If you eventually find a bug on
it, please ping me for us to send a fix.

Cheers,
Mauro

  reply	other threads:[~2009-09-01 13:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090730200714.5a7ab8a6@pedra.chehab.org>
     [not found] ` <37219a840907310825n51d5a6bar79ea1f31dd889327@mail.gmail.com>
     [not found]   ` <20090801014053.7f53da83@pedra.chehab.org>
     [not found]     ` <303a8ee30908011103n3c12258icd2bfd1305b419d3@mail.gmail.com>
     [not found]       ` <20090811140128.211d4d11@caramujo.chehab.org>
     [not found]         ` <37219a840908111457o4b6abc64n52291f044b56782d@mail.gmail.com>
     [not found]           ` <37219a840908241332w2e2d45d8kd6406de3e60d1317@mail.gmail.com>
2009-08-30 12:53             ` [PULL] http://kernellabs.com/hg/~mkrufky/sms1xxx Michael Krufky
2009-08-30 22:13               ` Mauro Carvalho Chehab
2009-08-31 11:03                 ` Michael Krufky
2009-09-01 13:47                   ` Mauro Carvalho Chehab [this message]
2009-09-01 15:03                     ` Michael Krufky
2009-09-01 19:36                       ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090901104731.5f119d53@pedra.chehab.org \
    --to=mchehab@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mkrufky@kernellabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.