All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	roel kluin <roel.kluin@gmail.com>,
	netdev@vger.kernel.org
Subject: linux-next: net tree build warning
Date: Fri, 4 Sep 2009 14:28:46 +1000	[thread overview]
Message-ID: <20090904142846.02ad1b23.sfr@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

Hi Dave,

Today's linux-next build (x86_64 allmodconfig gcc-4.4.0) produced this
warning:

drivers/net/wan/dscc4.c: In function 'dscc4_rx_skb':
drivers/net/wan/dscc4.c:670: warning: suggest parentheses around comparison in operand of '|'

which actually points out a bug, I think.  It is doing
	(x & (y | z)) != y | z
when it probably means
	(x & (y | z)) != (y | z)

Introduced by commit 5de3fcab91b0e1809eec030355d15801daf25083 ("WAN: bit
and/or confusion").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2009-09-04  4:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-04  4:28 Stephen Rothwell [this message]
2009-09-04  4:35 ` linux-next: net tree build warning David Miller
  -- strict thread matches above, loose matches on Subject: below --
2009-11-30  5:40 Stephen Rothwell
2009-11-30  9:49 ` Andrei Pelinescu-Onciul
2009-11-12  2:24 Stephen Rothwell
2009-11-12  2:53 ` David Miller
2009-11-12  2:55   ` Eric Dumazet
2009-11-12  3:10   ` Stephen Rothwell
2009-11-05  2:30 Stephen Rothwell
     [not found] <20090904144232.1f6ccf45.sfr@canb.auug.org.au>
2009-09-07  9:04 ` David Miller
2009-09-07  9:37   ` Stephen Rothwell
2009-06-09 10:36 Stephen Rothwell
2009-06-09 11:25 ` Wolfgang Grandegger
2009-06-09 11:26   ` David Miller
2009-06-09 13:14     ` Wolfgang Grandegger
2009-06-10  0:38       ` David Miller
2009-06-10  7:38         ` Wolfgang Grandegger
2009-06-10  8:12           ` David Miller
2009-05-22  5:16 Stephen Rothwell
2009-05-22  6:30 ` David Miller
2009-05-22  8:20   ` Stephen Rothwell
2009-05-22 10:31     ` Neil Horman
2009-03-12  5:58 Stephen Rothwell
2009-03-12  6:24 ` David Miller
2009-03-12  6:42   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904142846.02ad1b23.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.