All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] TQM85xx: enable partition support, sort commands
Date: Thu, 10 Sep 2009 13:55:28 +0200	[thread overview]
Message-ID: <20090910115528.7A803832E8DE@gemini.denx.de> (raw)
In-Reply-To: <D09E46D6-37C0-44E4-A7E9-4042BCF63B37@kernel.crashing.org>

Dear Kumar Gala,

In message <D09E46D6-37C0-44E4-A7E9-4042BCF63B37@kernel.crashing.org> you wrote:
> 
> > It's a problem that exists independent of this patch, you get the same
> > errors before. The problems are caused by your commit ec79d33 ("85xx:
> > Move to a common linker script").
> >
> > I reported this problem before, but it seems you missed that, see:
> > http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65788/focus=67568
> >
> >
> > I hoped you would fix this problem (or we can revert commit ec79d33?)
> 
> Ok. I think we are see two issues interact.
> 
> I've just sent a pull request w/the RESET_VECTOR_ADDRESS fix that  
> should address the linker script issue.  These seems to build cleanly  
> on all 85xx platforms w/ELDK4.2 for me.
> 
> Now if you apply the TQM85xx.h on top of that you will see that the  
> enabling of new features causes the size to increase beyond what is  
> allocated for TQM8540.

Maybe. But this is just another manifestation of the original problem:
without commit ec79d33 we didn't need the RESET_VECTOR_ADDRESS stuff
at all, and an image size of 256 kB was sufficient without and with
the "TQM85xx: enable partition suppor" patch applied.

Now, after commit ec79d33 (which needed to be fixed by the
RESET_VECTOR_ADDRESS stuff in the first place), we suddenly need more
than 256 kB.

This obviously means that commit ec79d33 introduced changes to the
image layout that make it bigger.

I consider this a bug in commit ec79d33. I don't want to waste more
space than needed.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A committee is a group that keeps the minutes and loses hours.
                                                      -- Milton Berle

  reply	other threads:[~2009-09-10 11:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-02  8:20 [U-Boot] [PATCH] TQM85xx: enable partition support, sort commands Wolfgang Denk
2009-09-02 21:41 ` Kumar Gala
2009-09-08 14:08 ` Kumar Gala
2009-09-08 19:50   ` Wolfgang Denk
2009-09-08 19:50 ` [U-Boot] [PATCH v2] " Wolfgang Denk
2009-09-08 20:29 ` [U-Boot] [PATCH v3] " Wolfgang Denk
2009-09-10  2:02   ` Kumar Gala
2009-09-10  7:56     ` Wolfgang Denk
2009-09-10  8:57       ` Kumar Gala
2009-09-10 11:55         ` Wolfgang Denk [this message]
2009-09-10 14:41           ` Kumar Gala
2009-09-15 15:28             ` Kumar Gala
2009-09-15 19:40               ` Wolfgang Denk
2009-10-16 17:44   ` Kumar Gala
2009-10-18 21:16     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090910115528.7A803832E8DE@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.