All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Frank Mayhar <fmayhar@google.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Make non-journal fsync work properly.
Date: Thu, 10 Sep 2009 15:45:42 -0400	[thread overview]
Message-ID: <20090910194542.GH23700@mit.edu> (raw)
In-Reply-To: <1252596786.2130.6.camel@bobble.smo.corp.google.com>

On Thu, Sep 10, 2009 at 08:33:06AM -0700, Frank Mayhar wrote:
> 
> I've been following the other thread as well.  I think I'm beginning to
> get a handle on just how the buffer_heads and ext4 inodes work but I
> still have some learning to do.  That having been said, however, it's
> clear that this change does make things work much, much better, as seen
> by the improvement in our power-fail tests.  One way or another, the
> inodes are getting flushed.  After reading the other thread, I'm
> beginning to suspect that it's more as a side effect of the current
> tangle rather than because of it.  I'll have to look further to
> understand just why it's working, though.
> 
> In any event, I think this change does the right thing or is at least a
> step in the right direction.

Could you also test and give feedback for my patch, "ext4: Assure that
metadata blocks are written during fsync in no journal mode"?  I'm not
sure how much your workloads care about fsync() working correctly, but
it's something we should get right for no-journal mode.

Thanks,

						- Ted

      reply	other threads:[~2009-09-10 19:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-05  2:55 [PATCH] Make non-journal fsync work properly Frank Mayhar
2009-09-08  5:06 ` Theodore Tso
2009-09-08 14:57   ` Curt Wohlgemuth
2009-09-08 21:41     ` Theodore Tso
2009-09-08 15:41   ` Frank Mayhar
2009-09-08 22:05     ` Theodore Tso
2009-09-08 22:39       ` Frank Mayhar
2009-09-09 17:34       ` [PATCH] ext4: Make non-journal fsync work properly. REPOST Frank Mayhar
2009-09-10  2:55         ` Theodore Tso
2009-09-14 16:54         ` Aneesh Kumar K.V
2009-09-14 17:43           ` Frank Mayhar
2009-09-26  0:39         ` [PATCH] ext4: Make non-journal fsync work properly. (Version 3) Frank Mayhar
2009-09-29 14:09           ` Theodore Tso
2009-09-10  6:57 ` [PATCH] Make non-journal fsync work properly Aneesh Kumar K.V
2009-09-10 15:33   ` Frank Mayhar
2009-09-10 19:45     ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090910194542.GH23700@mit.edu \
    --to=tytso@mit.edu \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=fmayhar@google.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.