From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754195AbZIJUk5 (ORCPT ); Thu, 10 Sep 2009 16:40:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753977AbZIJUk4 (ORCPT ); Thu, 10 Sep 2009 16:40:56 -0400 Received: from verein.lst.de ([213.95.11.210]:43891 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbZIJUkz (ORCPT ); Thu, 10 Sep 2009 16:40:55 -0400 Date: Thu, 10 Sep 2009 22:40:26 +0200 From: Christoph Hellwig To: Trond Myklebust Cc: Christoph Hellwig , Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, drepper@redhat.com, viro@zeniv.linux.org.uk, kyle@mcmartin.ca Subject: Re: [PATCH 18/16] implement posix O_SYNC and O_DSYNC semantics Message-ID: <20090910204026.GA20797@lst.de> References: <1251899966-7316-1-git-send-email-jack@suse.cz> <20090910202521.GA20261@lst.de> <1252615120.8722.148.camel@heimdal.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1252615120.8722.148.camel@heimdal.trondhjem.org> User-Agent: Mutt/1.3.28i X-Spam-Score: -0.127 () BAYES_20 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2009 at 04:38:40PM -0400, Trond Myklebust wrote: > > return vfs_fsync_range(file, file->f_path.dentry, pos, > > - pos + count - 1, 1); > > + pos + count - 1, > > + (file->f_flags & O_SYNC) ? 1 : 0); > > } > > EXPORT_SYMBOL(generic_write_sync); > > > Shouldn't this be testing for > > file->f_flags & __O_SYNC > > ? Doesn't matter, we check early in the open path that __O_SYNC is only set together with O_SYNC.