From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from cpsmtpm-eml105.kpnxchange.com ([195.121.3.9]:60057 "EHLO CPSMTPM-EML105.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbZIJSnQ (ORCPT ); Thu, 10 Sep 2009 14:43:16 -0400 From: Frans Pop To: reinette chatre Subject: Re: iwlagn: order 2 page allocation failures Date: Thu, 10 Sep 2009 20:43:13 +0200 Cc: Mel Gorman , Larry Finger , "John W. Linville" , Pekka Enberg , "linux-kernel@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "ipw3945-devel@lists.sourceforge.net" , Andrew Morton , "cl@linux-foundation.org" , "Krauss, Assaf" , Johannes Berg , "Abbas, Mohamed" References: <200909060941.01810.elendil@planet.nl> <20090910090206.GA22276@csn.ul.ie> <1252606547.30150.304.camel@rc-desk> In-Reply-To: <1252606547.30150.304.camel@rc-desk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <200909102043.17883.elendil@planet.nl> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thursday 10 September 2009, reinette chatre wrote: > From: Reinette Chatre > Date: Wed, 9 Sep 2009 15:41:00 -0700 > Subject: [PATCH] iwlwifi: reduce noise when skb allocation fails Looks good to me (from a user's perspective). IIUC the first message is now only displayed if IWL debugging is explicitly enabled, and the second only if there really is danger of it affecting data transfer and has been made more informative too. It seems to me that, with debugging enabled, the "Failed to allocate SKB buffer." message may get repeated, but I guess that's minor. One nitpick. As you've made the message into sentences, "Only %u free buffers remaining" should IMO also end with a period. Thanks, FJP From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753083AbZIJSnS (ORCPT ); Thu, 10 Sep 2009 14:43:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752913AbZIJSnQ (ORCPT ); Thu, 10 Sep 2009 14:43:16 -0400 Received: from cpsmtpm-eml105.kpnxchange.com ([195.121.3.9]:60057 "EHLO CPSMTPM-EML105.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbZIJSnQ (ORCPT ); Thu, 10 Sep 2009 14:43:16 -0400 From: Frans Pop To: reinette chatre Subject: Re: iwlagn: order 2 page allocation failures Date: Thu, 10 Sep 2009 20:43:13 +0200 User-Agent: KMail/1.9.9 Cc: Mel Gorman , Larry Finger , "John W. Linville" , Pekka Enberg , "linux-kernel@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "ipw3945-devel@lists.sourceforge.net" , Andrew Morton , "cl@linux-foundation.org" , "Krauss, Assaf" , Johannes Berg , "Abbas, Mohamed" References: <200909060941.01810.elendil@planet.nl> <20090910090206.GA22276@csn.ul.ie> <1252606547.30150.304.camel@rc-desk> In-Reply-To: <1252606547.30150.304.camel@rc-desk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200909102043.17883.elendil@planet.nl> X-OriginalArrivalTime: 10 Sep 2009 18:43:18.0482 (UTC) FILETIME=[90607320:01CA3246] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 September 2009, reinette chatre wrote: > From: Reinette Chatre > Date: Wed, 9 Sep 2009 15:41:00 -0700 > Subject: [PATCH] iwlwifi: reduce noise when skb allocation fails Looks good to me (from a user's perspective). IIUC the first message is now only displayed if IWL debugging is explicitly enabled, and the second only if there really is danger of it affecting data transfer and has been made more informative too. It seems to me that, with debugging enabled, the "Failed to allocate SKB buffer." message may get repeated, but I guess that's minor. One nitpick. As you've made the message into sentences, "Only %u free buffers remaining" should IMO also end with a period. Thanks, FJP