From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Troy Kisky <troy.kisky@boundarydevices.com>
Cc: khilman@deeprootsystems.com,
davinci-linux-open-source@linux.davincidsp.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] RFC: ASoC: Davinci: Fix data_type divide by zero
Date: Fri, 11 Sep 2009 11:31:39 +0100 [thread overview]
Message-ID: <20090911103139.GA19204@sirena.org.uk> (raw)
In-Reply-To: <1252547830-16585-1-git-send-email-troy.kisky@boundarydevices.com>
On Wed, Sep 09, 2009 at 06:57:10PM -0700, Troy Kisky wrote:
> This applies on top of my last patchset to Kevin's temp/asoc branch
Could you please respin against what's in for-2.6.32 - this ought to get
fixed there but the other changes will need to wait for 2.6.33.
> struct davinci_mcbsp_dev {
> + /*
> + * dma_params must be first because rtd->dai->cpu_dai->private_data
> + * is cast to an array of struct davinci_pcm_dma_params ** in
> + * davinci_pcm_open.
> + */
Is it not possible to deal with this by going through the types
properly? The comment sets off all sorts of alarm bells.
next prev parent reply other threads:[~2009-09-11 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 1:57 [PATCH] RFC: ASoC: Davinci: Fix data_type divide by zero Troy Kisky
2009-09-11 10:31 ` Mark Brown [this message]
2009-09-11 21:27 ` Troy Kisky
2009-09-12 12:19 ` Mark Brown
2009-09-14 22:04 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911103139.GA19204@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.