From: Clemens Buchacher <drizzd@aon.at>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] preserve mtime of local clone
Date: Sat, 12 Sep 2009 10:26:24 +0200 [thread overview]
Message-ID: <20090912082624.GA9654@localhost> (raw)
In-Reply-To: <7vmy50lpfr.fsf@alter.siamese.dyndns.org>
On Fri, Sep 11, 2009 at 10:09:12PM -0700, Junio C Hamano wrote:
> Clemens Buchacher <drizzd@aon.at> writes:
>
> > +int copy_times(int ofd, int ifd)
> > +{
> > + struct stat st;
> > + struct timespec times[2];
> > + if (fstat(ifd, &st))
> > + return -1;
> > + times[0].tv_nsec = UTIME_OMIT;
> > + times[1].tv_sec = st.st_mtime;
> > + times[1].tv_nsec = ST_MTIME_NSEC(st);
> > + return futimens(ofd, times);
> > +}
>
> Hmm, futimens() is relatively new. Are minority platforms folks Ok with
> this patch?
>
> At least SunOS 5.11 (OpenSolaris 0811) seems to barf on UTIME_OMIT.
If it's a problem we can use utime() instead. I was just trying to use the
file descriptors, since they were available. But the patch would be a little
smaller if I didn't touch copy_fd().
Clemens
next prev parent reply other threads:[~2009-09-12 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 19:51 [PATCH] preserve mtime of local clone Clemens Buchacher
2009-09-12 5:09 ` Junio C Hamano
2009-09-12 8:26 ` Clemens Buchacher [this message]
2009-09-12 9:03 ` Clemens Buchacher
2009-09-13 3:06 ` Junio C Hamano
2009-09-13 10:49 ` [PATCH v3] " Clemens Buchacher
2009-09-13 16:06 ` [PATCH] git-gui: suggest gc only when counting at least 2 objects Clemens Buchacher
2009-09-13 17:58 ` Junio C Hamano
2009-09-13 18:41 ` Clemens Buchacher
2009-09-13 20:44 ` Jeff King
2009-09-13 21:19 ` Clemens Buchacher
2009-09-13 22:20 ` [PATCH] git-gui: search 4 directories to improve statistic of gc hint Clemens Buchacher
2009-09-14 3:39 ` [PATCH] git-gui: suggest gc only when counting at least 2 objects Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912082624.GA9654@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.