From: Marcelo Tosatti <mtosatti@redhat.com>
To: Izik Eidus <ieidus@redhat.com>
Cc: avi@redhat.com, kvm@vger.kernel.org, aarcange@redhat.com
Subject: Re: [PATCH 3/3] add support for change_pte mmu notifiers
Date: Sat, 12 Sep 2009 13:59:27 -0300 [thread overview]
Message-ID: <20090912165927.GA4311@amt.cnet> (raw)
In-Reply-To: <4AABD49F.8040000@redhat.com>
On Sat, Sep 12, 2009 at 08:04:31PM +0300, Izik Eidus wrote:
>>>> If change_pte is called to modify a largepage pte, and the shadow has
>>>> that largepage mapped with 4k sptes, you'll set the wrong pfn. That is,
>>>> the patch does not attempt to handle different page sizes properly.
>>>>
>>>> So either disable change_pte updates to non-4k host vmas (making it
>>>> explictly it does not handle different pagesizes), or handle largepages
>>>> properly, although i don't see any use for change_pte or largepage
>>>> mappings?
>>>>
>>> change_pte doesn't get called on 4k pages...
>>> So adding commet to this function saying it is working just on 4k
>>> pages would be enough ?
>>>
>>
>> It would be better to fail/WARN on non-4k host ptes (can't it?), but if
>> that is not possible i think a comment would be enough.
>>
>>
> Ok so you want is_large_pte() check on data right? (and WARN() there..)
pte_huge(pte), yeah.
next prev parent reply other threads:[~2009-09-12 16:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 16:38 [PATCH 0/3] ksm support for kvm Izik Eidus
2009-09-10 16:38 ` [PATCH 1/3] kvm: dont hold pagecount reference for mapped sptes pages Izik Eidus
2009-09-10 16:38 ` [PATCH 2/3] add SPTE_HOST_WRITEABLE flag to the shadow ptes Izik Eidus
2009-09-10 16:38 ` [PATCH 3/3] add support for change_pte mmu notifiers Izik Eidus
2009-09-11 21:24 ` Marcelo Tosatti
2009-09-12 6:41 ` Izik Eidus
2009-09-12 16:18 ` Marcelo Tosatti
2009-09-12 17:04 ` Izik Eidus
2009-09-12 16:59 ` Marcelo Tosatti [this message]
2009-09-11 21:14 ` [PATCH 2/3] add SPTE_HOST_WRITEABLE flag to the shadow ptes Marcelo Tosatti
2009-09-12 6:35 ` Izik Eidus
2009-09-14 5:18 ` Avi Kivity
2009-09-14 8:34 ` Marcelo Tosatti
2009-09-14 16:51 ` Izik Eidus
2009-09-23 18:25 [PATCH 0/3] ksm support for kvm v2 Izik Eidus
2009-09-23 18:25 ` [PATCH 1/3] kvm: dont hold pagecount reference for mapped sptes pages Izik Eidus
2009-09-23 18:25 ` [PATCH 2/3] add SPTE_HOST_WRITEABLE flag to the shadow ptes Izik Eidus
2009-09-23 18:25 ` [PATCH 3/3] add support for change_pte mmu notifiers Izik Eidus
2009-09-23 18:32 ` Izik Eidus
2009-09-23 18:47 [PATCH 0/3] kvm ksm support v3 Izik Eidus
2009-09-23 18:47 ` [PATCH 1/3] kvm: dont hold pagecount reference for mapped sptes pages Izik Eidus
2009-09-23 18:47 ` [PATCH 2/3] add SPTE_HOST_WRITEABLE flag to the shadow ptes Izik Eidus
2009-09-23 18:47 ` [PATCH 3/3] add support for change_pte mmu notifiers Izik Eidus
2009-09-24 14:55 ` Marcelo Tosatti
2009-09-24 17:11 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912165927.GA4311@amt.cnet \
--to=mtosatti@redhat.com \
--cc=aarcange@redhat.com \
--cc=avi@redhat.com \
--cc=ieidus@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.