From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755143AbZIMVCS (ORCPT ); Sun, 13 Sep 2009 17:02:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752144AbZIMVCR (ORCPT ); Sun, 13 Sep 2009 17:02:17 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:37101 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572AbZIMVCQ (ORCPT ); Sun, 13 Sep 2009 17:02:16 -0400 Date: Sun, 13 Sep 2009 14:02:05 -0700 From: Randy Dunlap To: Andrew Vasquez Cc: James Bottomley , Linux SCSI Mailing List , Stephen Rothwell , "linux-next@vger.kernel.org" , LKML , Giridhar Malavali , Ravi Anand , Lalit Chandivade Subject: Re: [PATCHv3] qla2xxx: Correct compilation issues when CONFIG_MODULES=n. Message-Id: <20090913140205.3a684f7c.randy.dunlap@oracle.com> In-Reply-To: <20090912164356.GA19451@plap4-2.local> References: <20090907210206.7830ba68.sfr@canb.auug.org.au> <20090907102747.ac6b98ff.randy.dunlap@oracle.com> <20090908182541.GB44157@plap4-2.local> <20090911175341.GH710@plap4-2.local> <1252708951.13282.151.camel@mulgrave.site> <20090912000742.GB12098@plap4-2.local> <20090912001752.GC12098@plap4-2.local> <20090912003808.GD12098@plap4-2.local> <1252728393.13282.485.camel@mulgrave.site> <20090912164356.GA19451@plap4-2.local> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.12.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: abhmt012.oracle.com [141.146.116.21] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4AAD5DD0.0112:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Sep 2009 09:43:56 -0700 Andrew Vasquez wrote: > Randy Dunlap noted: > > when CONFIG_MODULES=n: > > drivers/scsi/qla2xxx/qla_os.c:2685: error: dereferencing pointer to incomplete type > > in > > kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj, > KOBJ_CHANGE, envp); > > Trigger kobject event on the 'struct device' hanging off the pci_dev. > > Signed-off-by: Andrew Vasquez That works. Thanks for your persistence. Acked-by: Randy Dunlap > --- > > On Fri, 11 Sep 2009, James Bottomley wrote: > > > > diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c > > > index 29396c0..369a270 100644 > > > --- a/drivers/scsi/qla2xxx/qla_os.c > > > +++ b/drivers/scsi/qla2xxx/qla_os.c > > > @@ -2683,8 +2683,7 @@ qla2x00_uevent_emit(struct scsi_qla_host *vha, u32 code) > > > /* do nothing */ > > > break; > > > } > > > - kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj, > > > - KOBJ_CHANGE, envp); > > > + kobject_uevent_env(&(&vha->hw->pdev->dev)->kobj, KOBJ_CHANGE, envp); > > > > Much better. Of course to be perfect, you might like to remember that > > (&x)->y is actually x.y > > > > so > > > > kobject_uevent_env(&vha->hw->pdev->dev.kobj, ... > > Ahh, of course... Perfection...the enemy of progress... > > diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c > index 29396c0..86f337f 100644 > --- a/drivers/scsi/qla2xxx/qla_os.c > +++ b/drivers/scsi/qla2xxx/qla_os.c > @@ -2683,8 +2683,7 @@ qla2x00_uevent_emit(struct scsi_qla_host *vha, u32 code) > /* do nothing */ > break; > } > - kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj, > - KOBJ_CHANGE, envp); > + kobject_uevent_env(&vha->hw->pdev->dev.kobj, KOBJ_CHANGE, envp); > } > > void --- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/