All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan.kim@gmail.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>,
	Wu Fengguang <fengguang.wu@intel.com>,
	Minchan Kim <minchan.kim@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org
Subject: Re: Isolated(anon) and Isolated(file)
Date: Mon, 14 Sep 2009 08:24:30 +0900	[thread overview]
Message-ID: <20090914082430.13e06e4e.minchan.kim@barrios-desktop> (raw)
In-Reply-To: <Pine.LNX.4.64.0909132011550.28745@sister.anvils>

On Sun, 13 Sep 2009 20:42:38 +0100 (BST)
Hugh Dickins <hugh.dickins@tiscali.co.uk> wrote:

> Hi KOSAKI-san,
> 
> May I question the addition of Isolated(anon) and Isolated(file)
> lines to /proc/meminfo?  I get irritated by all such "0 kB" lines!
> 
> I see their appropriateness and usefulness in the Alt-Sysrq-M-style
> info which accompanies an OOM; and I see that those statistics help
> you to identify and fix bugs of having too many pages isolated.

Right. 
 
> But IMHO they're too transient to be appropriate in /proc/meminfo:
> by the time the "cat /proc/meminfo" is done, the situation is very
> different (or should be once the bugs are fixed).

I agree. 
 
> Almost all its numbers are transient, of course, but these seem
> so much so that I think /proc/meminfo is better off without them
> (compressing more info into fewer lines).
> 
> Perhaps I'm in the minority: if others care, what do they think?

At that time, we need isolated page count per zone. 
So we added it in zone_stat_item. 

As you know, most of zone_stat_item are fields of meminfo. 
So, I supported it as part of meminfo without serious thinking.
 
Now I agree with your opinion. 

It's very transient so it is valuable when OOM or Sysrq happens. 
If you get irritated by it, we can remove things related to meminfo 
but keep isolated count, then when we meets OOM, we can show it. 

Let's listen to others.

> Hugh


-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-09-13 23:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-13 19:42 Isolated(anon) and Isolated(file) Hugh Dickins
2009-09-13 23:24 ` Minchan Kim [this message]
2009-09-14  2:46 ` Wu Fengguang
2009-09-15  2:56 ` KOSAKI Motohiro
2009-09-15 15:30   ` Minchan Kim
2009-09-15 23:49   ` Wu Fengguang
2009-09-16  0:04   ` Hugh Dickins
2009-09-16  2:09     ` KOSAKI Motohiro
2009-09-16  2:19       ` Andrew Morton
2009-09-16  2:36         ` KOSAKI Motohiro
2009-09-16  3:20         ` Rik van Riel
2009-09-16  3:29         ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090914082430.13e06e4e.minchan.kim@barrios-desktop \
    --to=minchan.kim@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.