From: Randy Dunlap <randy.dunlap@oracle.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Greg KH <greg@kroah.com>,
arve@android.com, swetland@google.com,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch] Re: newer version of HTC Dream support
Date: Mon, 14 Sep 2009 12:56:20 -0700 [thread overview]
Message-ID: <20090914125620.81d98e1a.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20090914071136.GB7146@elf.ucw.cz>
On Mon, 14 Sep 2009 09:11:36 +0200 Pavel Machek wrote:
> Hi!
>
> > > #obj-y += audio_out.o audio_in.o audio_mp3.o audmgr.o audpp.o
> > > #obj-y += snd.o
> > >
> > > from build, the rest should now build ok.
> >
> > but still not link?
> >
> > drivers/staging/dream/camera/msm_camera.c:1482: undefined reference to `msm_camera_flash_set_led_state'
> >
> > CONFIG_MSM_CAMERA_FLASH=y
>
> It should link with the patch below...
Ack. All built now. Thanks.
> ---
>
> HTC Dream hardware has no camera flash, and current arm/mach-msm does
> not have flash support. Disable flash support for now.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/staging/dream/camera/Kconfig b/drivers/staging/dream/camera/Kconfig
> index 0a3e903..bfb6d24 100644
> --- a/drivers/staging/dream/camera/Kconfig
> +++ b/drivers/staging/dream/camera/Kconfig
> @@ -15,7 +15,7 @@ config MSM_CAMERA_DEBUG
>
> config MSM_CAMERA_FLASH
> bool "Qualcomm MSM camera flash support"
> - depends on MSM_CAMERA
> + depends on MSM_CAMERA && BROKEN
> ---help---
> Enable support for LED flash for msm camera
>
>
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
next prev parent reply other threads:[~2009-09-14 19:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 9:22 newer version of HTC Dream support Pavel Machek
2009-09-01 13:21 ` Pavel Machek
2009-09-04 16:03 ` Randy Dunlap
2009-09-11 7:16 ` Pavel Machek
2009-09-11 14:58 ` Randy Dunlap
2009-09-11 16:13 ` Pavel Machek
2009-09-11 16:21 ` Randy Dunlap
2009-09-11 21:27 ` [patch] " Pavel Machek
2009-09-11 22:34 ` Randy Dunlap
2009-09-13 8:37 ` Pavel Machek
2009-09-13 20:54 ` Randy Dunlap
2009-09-13 22:11 ` Pavel Machek
2009-09-13 22:25 ` Pavel Machek
2009-09-13 22:38 ` Pavel Machek
2009-09-13 23:21 ` Randy Dunlap
2009-09-14 7:06 ` Pavel Machek
2009-09-14 7:11 ` Pavel Machek
2009-09-14 19:56 ` Randy Dunlap [this message]
2009-09-14 21:24 ` Greg KH
2009-09-14 21:46 ` Pavel Machek
2009-09-14 21:51 ` Greg KH
2009-09-14 21:54 ` Pavel Machek
2009-09-14 22:04 ` Greg KH
2009-09-14 22:21 ` Pavel Machek
2009-09-14 22:02 ` Pavel Machek
[not found] ` <20090916174803.GA28689@kroah.com>
2009-09-26 11:44 ` Staging: dream: fix build errorsg Pavel Machek
2009-09-26 18:48 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090914125620.81d98e1a.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=arve@android.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.