From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755573AbZINOzj (ORCPT ); Mon, 14 Sep 2009 10:55:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753980AbZINOzi (ORCPT ); Mon, 14 Sep 2009 10:55:38 -0400 Received: from eddie.linux-mips.org ([78.24.191.182]:57905 "EHLO eddie.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753421AbZINOzi (ORCPT ); Mon, 14 Sep 2009 10:55:38 -0400 Date: Mon, 14 Sep 2009 16:56:18 +0200 From: Ralf Baechle To: Julia Lawall Cc: Atsushi Nemoto , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap Message-ID: <20090914145618.GB1934@linux-mips.org> References: <20090913.232548.253168283.anemo@mba.ocn.ne.jp> <20090914.003321.160496287.anemo@mba.ocn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2009 at 09:15:18PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Error handling code following a kzalloc should free the allocated data. > Error handling code following an ioremap should iounmap the allocated data. > > The semantic match that finds the first problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) Guess this one looks right, applied. Thanks, Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Date: Mon, 14 Sep 2009 14:56:18 +0000 Subject: Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap Message-Id: <20090914145618.GB1934@linux-mips.org> List-Id: References: <20090913.232548.253168283.anemo@mba.ocn.ne.jp> <20090914.003321.160496287.anemo@mba.ocn.ne.jp> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Atsushi Nemoto , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Sun, Sep 13, 2009 at 09:15:18PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Error handling code following a kzalloc should free the allocated data. > Error handling code following an ioremap should iounmap the allocated data. > > The semantic match that finds the first problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) Guess this one looks right, applied. Thanks, Ralf