* [patch 15/18] kbuild: check if linker supports the -X option
@ 2009-09-14 21:49 akpm
0 siblings, 0 replies; 3+ messages in thread
From: akpm @ 2009-09-14 21:49 UTC (permalink / raw)
To: sam; +Cc: linux-kbuild, akpm, andi, ak
From: Andi Kleen <andi@firstfloor.org>
The new alternative `gold' linker in recent binutils doesn't support the
-X option. This breaks allyesconfig builds that have
CONFIG_STRIP_ASM_SYMS enabled. Check if the linker really supports the
option using ld-option.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN Makefile~kbuild-check-if-linker-supports-the-x-option Makefile
--- a/Makefile~kbuild-check-if-linker-supports-the-x-option
+++ a/Makefile
@@ -598,7 +598,7 @@ LDFLAGS_MODULE += $(LDFLAGS_BUILD_ID)
LDFLAGS_vmlinux += $(LDFLAGS_BUILD_ID)
ifeq ($(CONFIG_STRIP_ASM_SYMS),y)
-LDFLAGS_vmlinux += -X
+LDFLAGS_vmlinux += $(call ld-option, -X,)
endif
# Default kernel image to build when no specific target is given.
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 15/18] kbuild: check if linker supports the -X option
2009-09-18 19:49 akpm
@ 2009-09-19 1:53 ` Andi Kleen
0 siblings, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2009-09-19 1:53 UTC (permalink / raw)
To: akpm; +Cc: sam, linux-kbuild, andi
akpm@linux-foundation.org wrote:
> From: Andi Kleen <andi@firstfloor.org>
>
> The new alternative `gold' linker in recent binutils doesn't support the
> -X option. This breaks allyesconfig builds that have
> CONFIG_STRIP_ASM_SYMS enabled. Check if the linker really supports the
> option using ld-option.
I sent Sam an updated version of that patch and the "Fix ld-option to really work"
patch.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* [patch 15/18] kbuild: check if linker supports the -X option
@ 2009-09-18 19:49 akpm
2009-09-19 1:53 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: akpm @ 2009-09-18 19:49 UTC (permalink / raw)
To: sam; +Cc: linux-kbuild, akpm, andi, ak
From: Andi Kleen <andi@firstfloor.org>
The new alternative `gold' linker in recent binutils doesn't support the
-X option. This breaks allyesconfig builds that have
CONFIG_STRIP_ASM_SYMS enabled. Check if the linker really supports the
option using ld-option.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN Makefile~kbuild-check-if-linker-supports-the-x-option Makefile
--- a/Makefile~kbuild-check-if-linker-supports-the-x-option
+++ a/Makefile
@@ -598,7 +598,7 @@ LDFLAGS_MODULE += $(LDFLAGS_BUILD_ID)
LDFLAGS_vmlinux += $(LDFLAGS_BUILD_ID)
ifeq ($(CONFIG_STRIP_ASM_SYMS),y)
-LDFLAGS_vmlinux += -X
+LDFLAGS_vmlinux += $(call ld-option, -X,)
endif
# Default kernel image to build when no specific target is given.
_
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-19 1:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-14 21:49 [patch 15/18] kbuild: check if linker supports the -X option akpm
2009-09-18 19:49 akpm
2009-09-19 1:53 ` Andi Kleen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.