From: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
To: tytso@mit.edu, akpm@linux-foundation.org
Cc: sct@redhat.com, adilger@sun.com, linux-ext4@vger.kernel.org
Subject: [PATCH 2/3][RFC] ext3: add a message in remount/umount for ext3
Date: Tue, 15 Sep 2009 15:24:07 +0900 [thread overview]
Message-ID: <20090915152407.dd0fe2c8.toshi.okajima@jp.fujitsu.com> (raw)
From: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
ext3 doesn't log a record of having unmounted the filesystem. And ext3 doesn't
log a record when the filesystem is remounted also with read-only. Therefore
in the system log, we cannot judge whether or not at the certain time this
filesystem user touches it.
For enterprise users, they often want to know when a certain filesystem is
mounted/remounted/unmounted.
So, we output the message to the system log when the filesystem is
remounted/unmounted.
Signed-off-by: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
---
fs/ext3/super.c | 32 +++++++++++++++++++++++---------
1 file changed, 23 insertions(+), 9 deletions(-)
diff -Nurp linux-2.6.31.orig/fs/ext3/super.c linux-2.6.31/fs/ext3/super.c
--- linux-2.6.31.orig/fs/ext3/super.c 2009-09-10 07:13:59.000000000 +0900
+++ linux-2.6.31/fs/ext3/super.c 2009-09-11 17:08:24.742407628 +0900
@@ -328,6 +328,26 @@ void ext3_update_dynamic_rev(struct supe
*/
}
+static void ext3_print_mount_message(struct super_block *sb,
+ int is_remount)
+{
+ printk(KERN_INFO "EXT3 FS %s on %s, ",
+ is_remount? "remounted": "mounted", sb->s_id);
+ if (EXT3_SB(sb)->s_journal->j_inode == NULL) {
+ char b[BDEVNAME_SIZE];
+
+ printk("external journal on %s\n",
+ bdevname(EXT3_SB(sb)->s_journal->j_dev, b));
+ } else {
+ printk("internal journal\n");
+ }
+}
+
+static void ext3_print_umount_message(struct super_block *sb)
+{
+ printk(KERN_INFO "EXT3 FS unmounted from %s\n", sb->s_id);
+}
+
/*
* Open the external journal device
*/
@@ -448,6 +468,7 @@ static void ext3_put_super (struct super
sb->s_fs_info = NULL;
kfree(sbi->s_blockgroup_lock);
kfree(sbi);
+ ext3_print_umount_message(sb);
unlock_kernel();
}
@@ -1296,15 +1317,6 @@ static int ext3_setup_super(struct super
EXT3_INODES_PER_GROUP(sb),
sbi->s_mount_opt);
- printk(KERN_INFO "EXT3 FS on %s, ", sb->s_id);
- if (EXT3_SB(sb)->s_journal->j_inode == NULL) {
- char b[BDEVNAME_SIZE];
next reply other threads:[~2009-09-15 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 6:24 Toshiyuki Okajima [this message]
2009-09-15 14:23 ` [PATCH 2/3][RFC] ext3: add a message in remount/umount for ext3 Andreas Dilger
2009-09-16 4:49 ` Toshiyuki Okajima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915152407.dd0fe2c8.toshi.okajima@jp.fujitsu.com \
--to=toshi.okajima@jp.fujitsu.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sct@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.