All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Carsten Otte <cotte@de.ibm.com>,
	markmc@redhat.com, qemu-devel@nongnu.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	kraxel@redhat.com, Avi Kivity <avi@redhat.com>,
	Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu/qdev: type safety in reset handler
Date: Tue, 15 Sep 2009 23:42:05 +0300	[thread overview]
Message-ID: <20090915204205.GB27954@redhat.com> (raw)
In-Reply-To: <f43fc5580909151320r7c283a0dg63cb9e5452ed2e9b@mail.gmail.com>

On Tue, Sep 15, 2009 at 11:20:25PM +0300, Blue Swirl wrote:
> On Tue, Sep 15, 2009 at 5:33 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Add type safety to qdev reset handlers, by declaring them as
> > DeviceState * rather than void *.
> 
> The function seems a bit unnecessary,

which function?

> how about instead:

instead of which one?

> static void rtl8139_reset(struct DeviceState *d)
> {
>     RTL8139State *s = container_of(d, RTL8139State, dev.qdev);
> 
> ?

  reply	other threads:[~2009-09-15 20:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1253025151.git.mst@redhat.com>
2009-09-15 14:33 ` [Qemu-devel] [PATCH 1/2] qemu/qdev: type safety in reset handler Michael S. Tsirkin
2009-09-15 14:55   ` [Qemu-devel] " Gerd Hoffmann
2009-09-15 20:20   ` [Qemu-devel] " Blue Swirl
2009-09-15 20:42     ` Michael S. Tsirkin [this message]
2009-09-15 21:16       ` [Qemu-devel] " Paolo Bonzini
2009-09-15 21:37         ` Michael S. Tsirkin
2009-09-16 10:13           ` Gerd Hoffmann
2009-09-16 10:14             ` Michael S. Tsirkin
     [not found]   ` <m3vdjjutwa.fsf@neno.mitica>
2009-09-16  9:34     ` Michael S. Tsirkin
2009-09-16 10:05       ` Gerd Hoffmann
2009-09-16 10:06         ` Michael S. Tsirkin
2009-09-16 10:22           ` Gerd Hoffmann
2009-09-16 10:30             ` Michael S. Tsirkin
2009-09-16 10:47               ` Michael S. Tsirkin
2009-09-16 12:08             ` Michael S. Tsirkin
2009-09-15 14:33 ` [Qemu-devel] [PATCH 2/2] qemu/virtio: fix reset with device removal Michael S. Tsirkin
2009-09-15 15:30   ` [Qemu-devel] " Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090915204205.GB27954@redhat.com \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cotte@de.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=markmc@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.