Re: [LTP] [PATCH] ftest cleanup II

From: Cyril Hrubis <chrubis@suse.cz>
To: Subrata Modak <subrata@linux.vnet.ibm.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] ftest cleanup II
Date: Thu, 17 Sep 2009 13:42:22 +0200	[thread overview]
Message-ID: <20090917114222.GA26142@schrodinger.suse.cz> (raw)
In-Reply-To: <1253114228.6343.29.camel@subratamodak.linux.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi!
> > The previous patch had missing changes in Makefile and ftest04.c.
> > Fixed patch (that was tested on ltp cvs checkout) is attched.
> > 
> > Signed-off-by: Cyril Hrubis chrubis@suse.cz
> 
> This Fixes the earlier issues, but introduced a new one.
> 
> # make
> will work fine, but
> # make -j4
> will not,
> 
> because,
> 
> ltp/testcases/kernel/fs/ftest/libftest.o
> 
> may not have been created when:
> 
> # gcc ... libftest.o ftest01.c
> or,
> # gcc ... libftest.o ftest02.c
> 

Attached patch should fix this.

Signed-off-by: Cyril Hrubis chrubis@suse.cz

-- 
Cyril Hrubis
chrubis@suse.cz

[-- Attachment #2: ftest_makefile.patch --]
[-- Type: text/x-patch, Size: 721 bytes --]

Index: ltp/testcases/kernel/fs/ftest/Makefile
===================================================================

--- ltp.orig/testcases/kernel/fs/ftest/Makefile
+++ ltp/testcases/kernel/fs/ftest/Makefile
@@ -22,12 +22,14 @@
 # description	: make(1) description file for the send(2) tests.	  #
 ###########################################################################
 CFLAGS+=	-I../../../../include -W -Wall -g
-LOADLIBES+=	-L../../../../lib libftest.o -lltp
+LOADLIBES+=	-L../../../../lib -lltp
 
 SRCS=$(wildcard ftest*.c)
 TARGETS=$(patsubst %.c,%,$(SRCS))
 
-all: libftest.o $(TARGETS)
+all: $(TARGETS)
+
+$(TARGETS): libftest.o
 
 install:
 	@set -e; for i in $(TARGETS) ; do ln -f $$i ../../../bin/$$i ; done ;

[-- Attachment #3: Type: text/plain, Size: 401 bytes --]

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
