From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, fweisbec@gmail.com
Subject: Re: [PATCH 7/8] perf: Add a perf record --timechart option
Date: Sat, 19 Sep 2009 11:44:52 +0200 [thread overview]
Message-ID: <20090919094452.GA2295@elte.hu> (raw)
In-Reply-To: <20090914223303.0e595bb2@infradead.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> On Mon, 14 Sep 2009 10:06:00 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Sat, 2009-09-12 at 13:06 +0200, Arjan van de Ven wrote:
> > > This patch adds a "perf record --timechart" option, to make it easy
> > > to capture traces for use by the timechart tool.
> >
> > Would it perhaps make sense to make that:
> >
> > perf timechart record
>
> well yes, but it would just be an alias for the former, since it's the
> record code that has to do the recording... and that's a rather
> obscene layering violation in how perf is set up I think.
No, please do it like 'perf sched record' does - it constructs an
argument list of pre-cooked options. See builtin-sched.c's record_args[]
array.
Ingo
next prev parent reply other threads:[~2009-09-19 9:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090912130306.5d0086ea@infradead.org>
2009-09-12 11:03 ` [PATCH 1/8] perf: Add a timestamp to fork events Arjan van de Ven
2009-09-19 9:51 ` [tip:perfcounters/core] " tip-bot for Arjan van de Ven
2009-09-12 11:04 ` [PATCH 2/8] perf: Store trace event name/id pairs in perf.data Arjan van de Ven
2009-09-19 9:31 ` Ingo Molnar
2009-09-19 9:51 ` [tip:perfcounters/core] " tip-bot for Arjan van de Ven
2009-09-12 11:04 ` [PATCH 3/8] perf: Allow perf utilities to have "callback" options without arguments Arjan van de Ven
2009-09-19 9:52 ` [tip:perfcounters/core] " tip-bot for Arjan van de Ven
2009-09-12 11:05 ` [PATCH 4/8] perf: Add a sample_event type to the event_union Arjan van de Ven
2009-09-19 9:52 ` [tip:perfcounters/core] " tip-bot for Arjan van de Ven
2009-09-12 11:05 ` [PATCH 5/8] trace: Convert the power tracer into an event tracer Arjan van de Ven
2009-09-15 3:43 ` Li Zefan
2009-09-15 4:16 ` Arjan van de Ven
2009-09-19 9:52 ` [tip:perfcounters/core] tracing, perf: " tip-bot for Arjan van de Ven
2009-09-12 11:06 ` [PATCH 6/8] perf: Add a SVG helper library file Arjan van de Ven
2009-09-19 9:52 ` [tip:perfcounters/core] " tip-bot for Arjan van de Ven
2009-09-12 11:06 ` [PATCH 7/8] perf: Add a perf record --timechart option Arjan van de Ven
2009-09-14 8:06 ` Peter Zijlstra
2009-09-14 20:33 ` Arjan van de Ven
2009-09-19 9:44 ` Ingo Molnar [this message]
2009-09-19 11:03 ` [PATCH] perf: Add "perf timechart record" Arjan van de Ven
2009-09-12 11:07 ` [PATCH 8/8] perf: Add the timechart tool Arjan van de Ven
2009-09-19 9:48 ` Ingo Molnar
2009-09-19 9:51 ` Ingo Molnar
2009-09-19 9:53 ` [tip:perfcounters/core] " tip-bot for Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090919094452.GA2295@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.