From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbZIYHJM (ORCPT ); Fri, 25 Sep 2009 03:09:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752207AbZIYHJI (ORCPT ); Fri, 25 Sep 2009 03:09:08 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]:40792 "EHLO mail.valinux.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbZIYHJH (ORCPT ); Fri, 25 Sep 2009 03:09:07 -0400 Date: Fri, 25 Sep 2009 16:09:11 +0900 (JST) Message-Id: <20090925.160911.71102299.ryov@valinux.co.jp> To: balbir@linux.vnet.ibm.com Cc: kamezawa.hiroyu@jp.fujitsu.com, akpm@linux-foundation.org, vgoyal@redhat.com, linux-kernel@vger.kernel.org, jens.axboe@oracle.com, containers@lists.linux-foundation.org, dm-devel@redhat.com, nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, guijianfeng@cn.fujitsu.com, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, righi.andrea@gmail.com, m-ikeda@ds.jp.nec.com, agk@redhat.com, peterz@infradead.org, jmarchan@redhat.com, torvalds@linux-foundation.org, mingo@elte.hu, riel@redhat.com Subject: Re: IO scheduler based IO controller V10 From: Ryo Tsuruta In-Reply-To: <20090925052911.GK4590@balbir.in.ibm.com> References: <20090925100952.55c2dd7a.kamezawa.hiroyu@jp.fujitsu.com> <20090925101821.1de8091a.kamezawa.hiroyu@jp.fujitsu.com> <20090925052911.GK4590@balbir.in.ibm.com> X-Mailer: Mew version 5.2.52 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Balbir Singh wrote: > > > I think I must support dirty-ratio in memcg layer. But not yet. > > > > We need to add this to the TODO list. > > > OR...I'll add a bufferred-write-cgroup to track bufferred writebacks. > > And add a control knob as > > bufferred_write.nr_dirty_thresh > > to limit the number of dirty pages generetad via a cgroup. > > > > Because memcg just records a owner of pages but not records who makes them > > dirty, this may be better. Maybe I can reuse page_cgroup and Ryo's blockio > > cgroup code. > > Very good point, this is crucial for shared pages. > > > > > But I'm not sure how I should treat I/Os generated out by kswapd. > > > > Account them to process 0 :) How about accounting them to processes who make pages dirty? I think that a process which consumes more memory should get penalty. However, this allows a page request process to use other's bandwidth, but If a user doesn't want to swap-out the memory, the user should allocate enough memory for the process by using memcg in advance. Thanks, Ryo Tsuruta From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryo Tsuruta Subject: Re: IO scheduler based IO controller V10 Date: Fri, 25 Sep 2009 16:09:11 +0900 (JST) Message-ID: <20090925.160911.71102299.ryov@valinux.co.jp> References: <20090925100952.55c2dd7a.kamezawa.hiroyu@jp.fujitsu.com> <20090925101821.1de8091a.kamezawa.hiroyu@jp.fujitsu.com> <20090925052911.GK4590@balbir.in.ibm.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090925052911.GK4590@balbir.in.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: balbir@linux.vnet.ibm.com Cc: dhaval@linux.vnet.ibm.com, peterz@infradead.org, dm-devel@redhat.com, dpshah@google.com, jens.axboe@oracle.com, agk@redhat.com, paolo.valente@unimore.it, jmarchan@redhat.com, guijianfeng@cn.fujitsu.com, fernando@oss.ntt.co.jp, mikew@google.com, jmoyer@redhat.com, nauman@google.com, mingo@elte.hu, vgoyal@redhat.com, m-ikeda@ds.jp.nec.com, riel@redhat.com, lizf@cn.fujitsu.com, fchecconi@gmail.com, akpm@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, s-uchida@ap.jp.nec.com, righi.andrea@gmail.com, torvalds@linux-foundation.org List-Id: dm-devel.ids Hi, Balbir Singh wrote: > > > I think I must support dirty-ratio in memcg layer. But not yet. > > > > We need to add this to the TODO list. > > > OR...I'll add a bufferred-write-cgroup to track bufferred writebacks. > > And add a control knob as > > bufferred_write.nr_dirty_thresh > > to limit the number of dirty pages generetad via a cgroup. > > > > Because memcg just records a owner of pages but not records who makes them > > dirty, this may be better. Maybe I can reuse page_cgroup and Ryo's blockio > > cgroup code. > > Very good point, this is crucial for shared pages. > > > > > But I'm not sure how I should treat I/Os generated out by kswapd. > > > > Account them to process 0 :) How about accounting them to processes who make pages dirty? I think that a process which consumes more memory should get penalty. However, this allows a page request process to use other's bandwidth, but If a user doesn't want to swap-out the memory, the user should allocate enough memory for the process by using memcg in advance. Thanks, Ryo Tsuruta