All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: sparclinux@vger.kernel.org
Subject: Re: [patch 1/1] sparc32: convert to asm-generic/hardirq.h
Date: Fri, 25 Sep 2009 22:19:32 +0000	[thread overview]
Message-ID: <20090925151932.3bcd5363.akpm@linux-foundation.org> (raw)
In-Reply-To: <200909181959.n8IJx3qh005792@imap1.linux-foundation.org>

On Fri, 25 Sep 2009 14:59:47 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Fri, 25 Sep 2009 14:56:18 -0700
> 
> > Dave, could you please send along the config which broke Christoph's
> > patch?  It works OK with allnoconfig and defconfig for me.
> 
> arch/sparc/configs/sparc32_defconfig


OK.

In file included from include/asm-generic/hardirq.h:6,
                 from /usr/src/devel/arch/sparc/include/asm/hardirq_32.h:11,
                 from /usr/src/devel/arch/sparc/include/asm/hardirq.h:6,
                 from include/linux/hardirq.h:10,
                 from include/linux/interrupt.h:12,
                 from /usr/src/devel/arch/sparc/include/asm/irq_32.h:9,
                 from /usr/src/devel/arch/sparc/include/asm/irq.h:6,
                 from include/linux/nmi.h:8,
                 from kernel/sched.c:31:

How's this fix look?

 arch/sparc/include/asm/irq_32.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN arch/sparc/include/asm/irq_32.h~a arch/sparc/include/asm/irq_32.h
--- a/arch/sparc/include/asm/irq_32.h~a
+++ a/arch/sparc/include/asm/irq_32.h
@@ -6,10 +6,10 @@
 #ifndef _SPARC_IRQ_H
 #define _SPARC_IRQ_H
 
-#include <linux/interrupt.h>
-
 #define NR_IRQS    16
 
+#include <linux/interrupt.h>
+
 #define irq_canonicalize(irq)	(irq)
 
 extern void __init init_IRQ(void);
_
 

  parent reply	other threads:[~2009-09-25 22:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 19:59 [patch 1/1] sparc32: convert to asm-generic/hardirq.h akpm
2009-09-25 21:07 ` David Miller
2009-09-25 21:15 ` Andrew Morton
2009-09-25 21:18 ` David Miller
2009-09-25 21:26 ` Sam Ravnborg
2009-09-25 21:36 ` Andrew Morton
2009-09-25 21:40 ` Andrew Morton
2009-09-25 21:42 ` Andrew Morton
2009-09-25 21:45 ` Sam Ravnborg
2009-09-25 21:50 ` Sam Ravnborg
2009-09-25 21:56 ` Andrew Morton
2009-09-25 21:59 ` David Miller
2009-09-25 22:19 ` Andrew Morton [this message]
2009-09-25 22:28 ` David Miller
2009-09-28 22:55 ` akpm
2009-10-01 21:32 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090925151932.3bcd5363.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.