From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753295AbZI0Pb3 (ORCPT ); Sun, 27 Sep 2009 11:31:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753135AbZI0Pb2 (ORCPT ); Sun, 27 Sep 2009 11:31:28 -0400 Received: from relay2-v.mail.gandi.net ([217.70.178.76]:59926 "EHLO relay2-v.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753110AbZI0Pb2 (ORCPT ); Sun, 27 Sep 2009 11:31:28 -0400 Date: Sun, 27 Sep 2009 08:31:08 -0700 From: Josh Triplett To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com Subject: Re: [PATCH tip/core/rcu 2/2] rcu: Apply review feedback from Josh Triplett, part 4 Message-ID: <20090927153107.GA2445@feather> References: <20090927064753.GA9394@linux.vnet.ibm.com> <1254034191918-git-send-email-> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254034191918-git-send-email-> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 26, 2009 at 11:49:51PM -0700, Paul E. McKenney wrote: > These issues identified during an old-fashioned face-to-face code > review extending over many hours. This group improves an existing > abstraction and introduces two new ones. > > o Make RCU_INIT_FLAVOR() declare its own variables, removing > the need to declare them at each call site. > > o Create an rcu_for_each_leaf() macro that scans the leaf nodes > of the rcu_node tree. > > o Create an rcu_for_each_node_breadth_first() macro that does > a breadth-first traversal of the rcu_node tree, AKA stepping > through the array in index-number order. > > Signed-off-by: Paul E. McKenney I noticed one bit of unrelated code in this patch, which the commit message doesn't mention: > --- a/kernel/rcutree.c > +++ b/kernel/rcutree.c [...] > @@ -473,18 +471,24 @@ static void print_other_cpu_stall(struct rcu_state *rsp) > return; > } > rsp->jiffies_stall = jiffies + RCU_SECONDS_TILL_STALL_RECHECK; > + > + /* > + * Now rat on any tasks that got kicked up to the root rcu_node > + * due to CPU offlining. > + */ > + rcu_print_task_stall(rnp); > spin_unlock_irqrestore(&rnp->lock, flags); - Josh Triplett