From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: [PATCH] ax25: Add missing dev_put in ax25_setsockopt Date: Mon, 28 Sep 2009 07:12:11 +0000 Message-ID: <20090928071211.GA8658@ff.dom.local> References: <20090921201157.GA5460@del.dom.local> <4ABA9058.3010605@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Bernard Pidoux F6BVP , Bernard Pidoux , Ralf Baechle DL5RB , Linux Netdev List , linux-hams To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <4ABA9058.3010605@free.fr> Sender: linux-hams-owner@vger.kernel.org List-Id: netdev.vger.kernel.org There is no dev_put ending positive SO_BINDTODEVICE call in ax25_setsockopt and no matching dev_put later. This ref isn't used by ax25_cb's because it's handled with up and down device events. BTW of reported-by: Bernard Pidoux F6BVP Signed-off-by: Jarek Poplawski --- net/ax25/af_ax25.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index fbcac76..3eee8eb 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c @@ -663,6 +663,7 @@ static int ax25_setsockopt(struct socket *sock, int level, int optname, ax25->ax25_dev = ax25_dev_ax25dev(dev); ax25_fillin_cb(ax25, ax25->ax25_dev); + dev_put(dev); break; default: