From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Don't enable interrupts in the page fault path
Date: Mon, 28 Sep 2009 08:17:56 +0000 [thread overview]
Message-ID: <20090928081756.GA7678@linux-sh.org> (raw)
In-Reply-To: <1253994245-3739-1-git-send-email-matt@console-pimps.org>
On Sat, Sep 26, 2009 at 08:44:05PM +0100, Matt Fleming wrote:
> There's already code in do_page_fault() to conditionally enable
> interrupts, so we don't need to unconditonally enable them before
> calling it. This fixes a lockdep warning where we called
> trace_hardirqs_off() but with irqs still enabled.
>
> Signed-off-by: Matt Fleming <matt@console-pimps.org>
This is a relic from the days where do_page_fault() did not do the
conditional re-enabling. Applied, thanks.
prev parent reply other threads:[~2009-09-28 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 19:44 [PATCH] sh: Don't enable interrupts in the page fault path Matt Fleming
2009-09-28 8:17 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090928081756.GA7678@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.