From: Arnd Bergmann <arnd@arndb.de>
To: Chris Wright <chrisw@sous-sol.org>
Cc: "pv-drivers@vmware.com" <pv-drivers@vmware.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Greg Kroah-Hartman <greg@kroah.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Jeff Garzik <jgarzik@pobox.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Hemminger <shemminger@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3
Date: Tue, 29 Sep 2009 15:05:50 +0200 [thread overview]
Message-ID: <200909291505.50961.arnd__32361.0192434446$1254229715$gmane$org@arndb.de> (raw)
In-Reply-To: <20090929085333.GC3958@sequoia.sous-sol.org>
On Tuesday 29 September 2009, Chris Wright wrote:
> > +struct Vmxnet3_MiscConf {
> > + struct Vmxnet3_DriverInfo driverInfo;
> > + uint64_t uptFeatures;
> > + uint64_t ddPA; /* driver data PA */
> > + uint64_t queueDescPA; /* queue descriptor table PA */
> > + uint32_t ddLen; /* driver data len */
> > + uint32_t queueDescLen; /* queue desc. table len in bytes */
> > + uint32_t mtu;
> > + uint16_t maxNumRxSG;
> > + uint8_t numTxQueues;
> > + uint8_t numRxQueues;
> > + uint32_t reserved[4];
> > +};
>
> should this be packed (or others that are shared w/ device)? i assume
> you've already done 32 vs 64 here
I would not mark it packed, because it already is well-defined on all
systems. You should add __packed only to the fields where you screwed
up, but not to structures that already work fine.
One thing that should possibly be fixed is the naming of identifiers, e.g.
's/Vmxnet3_MiscConf/vmxnet3_misc_conf/g', unless these header files are
shared with the host implementation.
Arnd <><
next prev parent reply other threads:[~2009-09-29 13:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 23:56 [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3 Shreyas Bhatewara
2009-09-28 23:56 ` Shreyas Bhatewara
2009-09-29 0:08 ` David Miller
2009-09-29 16:37 ` Shreyas Bhatewara
2009-09-29 16:37 ` Shreyas Bhatewara
2009-09-29 16:37 ` Shreyas Bhatewara
2009-09-29 0:08 ` David Miller
2009-09-29 0:20 ` Greg KH
2009-09-29 0:20 ` Greg KH
2009-09-29 0:47 ` [Pv-drivers] " Alok Kataria
2009-09-29 0:47 ` Alok Kataria
2009-09-29 0:22 ` Greg KH
2009-09-29 0:22 ` Greg KH
2009-09-29 0:51 ` [Pv-drivers] " Alok Kataria
2009-09-29 1:17 ` David Miller
2009-09-29 1:17 ` David Miller
2009-09-29 0:51 ` Alok Kataria
2009-09-29 8:53 ` Chris Wright
2009-09-29 8:53 ` Chris Wright
2009-09-29 13:05 ` Arnd Bergmann
2009-09-29 19:52 ` [Pv-drivers] " Bhavesh Davda
2009-09-29 19:55 ` David Miller
2009-09-29 21:23 ` Arnd Bergmann
2009-09-29 21:23 ` Arnd Bergmann
2009-09-29 19:55 ` David Miller
2009-09-29 19:52 ` Bhavesh Davda
2009-09-29 13:05 ` Arnd Bergmann [this message]
2009-09-29 19:45 ` Bhavesh Davda
2009-09-29 19:45 ` Bhavesh Davda
2009-09-29 20:30 ` Chris Wright
2009-09-29 21:00 ` Bhavesh Davda
2009-09-29 21:54 ` Chris Wright
2009-09-29 21:54 ` Chris Wright
2009-09-29 21:00 ` Bhavesh Davda
2009-09-29 20:30 ` Chris Wright
2009-09-29 20:56 ` Shreyas Bhatewara
2009-09-29 20:56 ` Shreyas Bhatewara
-- strict thread matches above, loose matches on Subject: below --
2009-09-28 23:56 Shreyas Bhatewara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='200909291505.50961.arnd__32361.0192434446$1254229715$gmane$org@arndb.de' \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=anthony@codemonkey.ws \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=shemminger@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.