From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtEkr-0006zZ-Nn
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:03:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtEkm-0006vU-0y
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:03:04 -0400
Received: from [199.232.76.173] (port=39436 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtEkl-0006vH-7D
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:02:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9941)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1MtEkk-0002fs-IS
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:02:58 -0400
Date: Thu, 1 Oct 2009 11:32:19 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] char: Emit 'OPENED' events on char
	device open
Message-ID: <20091001060219.GA27894@amit-x200.redhat.com>
References: <1254225888-17093-1-git-send-email-amit.shah@redhat.com>
	<1254225888-17093-2-git-send-email-amit.shah@redhat.com>
	<4AC3C9FD.3050705@codemonkey.ws>
	<20091001045622.GB18563@amit-x200.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091001045622.GB18563@amit-x200.redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On (Thu) Oct 01 2009 [10:26:22], Amit Shah wrote:
> On (Wed) Sep 30 2009 [16:13:33], Anthony Liguori wrote:
> > Amit Shah wrote:
> >> Notify users of the char interface whenever the file / connection is
> >> opened.
> >>
> >> The existing RESET event is triggered when the qemu char state is reset
> >> as well; which may not be as interesting as char device open events.
> >>
> >> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> >>   
> >
> > This series breaks the build (ppc440_bamboo.c).
> 
> This patch or this series? If it's this patch, that's surprising!

OK; it's the other patch. This ppc440 machine also init'ed the
virtio-console-pci the way pc.c did; I'll remove this as well.

		Amit