From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtFzO-0006cb-CR for qemu-devel@nongnu.org; Thu, 01 Oct 2009 03:22:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtFzK-0006YA-Rh for qemu-devel@nongnu.org; Thu, 01 Oct 2009 03:22:10 -0400 Received: from [199.232.76.173] (port=57634 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtFzK-0006Xy-Ou for qemu-devel@nongnu.org; Thu, 01 Oct 2009 03:22:06 -0400 Received: from mx20.gnu.org ([199.232.41.8]:27730) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MtFzK-0006gR-By for qemu-devel@nongnu.org; Thu, 01 Oct 2009 03:22:06 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtFzJ-00068n-94 for qemu-devel@nongnu.org; Thu, 01 Oct 2009 03:22:05 -0400 Date: Thu, 1 Oct 2009 16:22:03 +0900 From: Isaku Yamahata Message-ID: <20091001072203.GX24813%yamahata@valinux.co.jp> References: <1254305917-14784-1-git-send-email-yamahata@valinux.co.jp> <1254305917-14784-23-git-send-email-yamahata@valinux.co.jp> <20090930115522.GM18802@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090930115522.GM18802@redhat.com> Subject: [Qemu-devel] Re: [PATCH 22/61] pci: use appropriate PRIs in PCI_DPRINTF(). List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Wed, Sep 30, 2009 at 01:55:22PM +0200, Michael S. Tsirkin wrote: > On Wed, Sep 30, 2009 at 07:17:58PM +0900, Isaku Yamahata wrote: > > use appropriate PRIs in PCI_DPRINTF() for portability. > > > > Signed-off-by: Isaku Yamahata > > > I'm confused. Shouldn't we be getting 64 bit now? No. The address below is for PCI configuration space offset which remains 32 bit. The address getting 64 bit is pci bus address. > > > --- > > hw/pci.c | 10 ++++++---- > > 1 files changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/hw/pci.c b/hw/pci.c > > index 5c59092..4a7568d 100644 > > --- a/hw/pci.c > > +++ b/hw/pci.c > > @@ -561,7 +561,7 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t val, int len) > > int config_addr, bus_num; > > > > #if 0 > > - PCI_DPRINTF("pci_data_write: addr=%08x val=%08x len=%d\n", > > + PCI_DPRINTF("pci_data_write: addr=%08"PRIx32" val=%08"PRIx32" len=%d\n", > > addr, val, len); > > #endif > > bus_num = (addr >> 16) & 0xff; > > @@ -573,7 +573,8 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t val, int len) > > if (!pci_dev) > > return; > > config_addr = addr & 0xff; > > - PCI_DPRINTF("pci_config_write: %s: addr=%02x val=%08x len=%d\n", > > + PCI_DPRINTF("pci_config_write: %s: " > > + "addr=%02"PRIx32" val=%08"PRI32x" len=%d\n", > > pci_dev->name, config_addr, val, len); > > pci_dev->config_write(pci_dev, config_addr, val, len); > > } > > @@ -609,11 +610,12 @@ uint32_t pci_data_read(void *opaque, uint32_t addr, int len) > > } > > config_addr = addr & 0xff; > > val = pci_dev->config_read(pci_dev, config_addr, len); > > - PCI_DPRINTF("pci_config_read: %s: addr=%02x val=%08x len=%d\n", > > + PCI_DPRINTF("pci_config_read: %s: " > > + "addr=%02"PRIx32" val=%08"PRIx32" len=%d\n", > > pci_dev->name, config_addr, val, len); > > the_end: > > #if 0 > > - PCI_DPRINTF("pci_data_read: addr=%08x val=%08x len=%d\n", > > + PCI_DPRINTF("pci_data_read: addr=%08"PRIx32" val=%08"PRIx32" len=%d\n", > > addr, val, len); > > #endif > > return val; > -- yamahata