From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755118AbZJAIx4 (ORCPT ); Thu, 1 Oct 2009 04:53:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751587AbZJAIxz (ORCPT ); Thu, 1 Oct 2009 04:53:55 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:34406 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754761AbZJAIxy (ORCPT ); Thu, 1 Oct 2009 04:53:54 -0400 Date: Thu, 1 Oct 2009 10:53:55 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, Sam Ravnborg , Andrew Morton , Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH 06/34] don't use __devexit_p to wrap hal2_remove Message-ID: <20091001085355.GD2181@pengutronix.de> References: <20091001082607.GA2181@pengutronix.de> <1254385718-14254-6-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 01, 2009 at 10:36:59AM +0200, Takashi Iwai wrote: > At Thu, 1 Oct 2009 10:28:10 +0200, > Uwe Kleine-König wrote: > > > > The function hal2_remove is defined using __exit, so don't use __devexit_p > > but __exit_p to wrap it. > > I think it's the other way round. We should replace __exit with __devexit. > Ditto for sound/mips/sgio2audio.c. Actually both ways are possible. I choosed the alternative that doesn't add bloat to the kernel. The cost is that the device isn't hotplugable, but you can still unload the module to unbind the driver. I don't care much, but prefer slightly my approach as changing the patch is work for me :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |