From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755731AbZJAJbG (ORCPT ); Thu, 1 Oct 2009 05:31:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755383AbZJAJbF (ORCPT ); Thu, 1 Oct 2009 05:31:05 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:49091 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755243AbZJAJbF (ORCPT ); Thu, 1 Oct 2009 05:31:05 -0400 Date: Thu, 1 Oct 2009 11:31:06 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: "Michael S. Tsirkin" Cc: Christian Borntraeger , linux-kernel@vger.kernel.org, Sam Ravnborg , Andrew Morton , Rusty Russell Subject: Re: [PATCH 31/34] move virtrng_remove to .devexit.text Message-ID: <20091001093106.GA6386@pengutronix.de> References: <20091001082607.GA2181@pengutronix.de> <1254385718-14254-31-git-send-email-u.kleine-koenig@pengutronix.de> <200910011044.48293.borntraeger@de.ibm.com> <20091001091218.GE5718@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20091001091218.GE5718@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Oct 01, 2009 at 11:12:18AM +0200, Michael S. Tsirkin wrote: > On Thu, Oct 01, 2009 at 10:44:48AM +0200, Christian Borntraeger wrote: > > Am Donnerstag 01 Oktober 2009 10:28:35 schrieb Uwe Kleine-König: > > > The function virtrng_remove is used only wrapped by __devexit_p so define > > > it using __devexit. > > > > > > Signed-off-by: Uwe Kleine-König > > > Acked-by: Sam Ravnborg > > > Cc: Rusty Russell > > > Cc: Michael S. Tsirkin > > > Cc: Christian Borntraeger > > > > Acked-by: Christian Borntraeger > > FWIW > Acked-by: Michael S. Tsirkin ok > > It seems that there are similar changes possible in other virtio drivers (e.g. > > virtio_net). http://thread.gmane.org/gmane.linux.kernel/896297/focus=896309 > Yes, and more importantly drivers/virtio/virtio.c as well. Hm, I don't see it: $ git grep -E '__(dev)?exit_p' linus/master:drivers/virtio/virtio.c $ Well, you could add something, but adding __devexit is a noop for most kernels. It matters only if you don't have CONFIG_HOTPLUG. In this series I only addressed drivers that use __{,dev}exit and __{,dev}exit_p inconsistenly. I.e. my script greps for __{,dev}exit_p and checks the prototype of the wrapped function. I have another script that does a similar check for platform_devices in general. This one also notices if you have a __devexit function that isn't wrapped by __devexit_p. So if you want to see drivers/virtio/virtio.c improving, send patches yourself :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |