All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: manty@manty.net
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: kernel BUG at drivers/ide/ide-disk.c:187 (2.6.31)
Date: Thu, 1 Oct 2009 10:26:14 +0200	[thread overview]
Message-ID: <200910011026.17510.elendil@planet.nl> (raw)
In-Reply-To: <20090930235709.43ff1255.akpm@linux-foundation.org>

Hi Manty,

Andrew Morton wrote:
> On Wed, 30 Sep 2009 13:05:29 +0200 Santiago Garcia Mantinan wrote:
>> kernel BUG at drivers/ide/ide-disk.c:187!

Looks like this is a deliberate test for unknown requests that was added in 
2.6.31 with the following commit:

commit 2c7eaa43c3bb7b3b9fe2051d17f308c1f0728c78
Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date:   Mon Jun 15 22:16:10 2009 +0200

    ide: BUG() on unknown requests

    Unsupported requests should be never handed down to device drivers
    and the best thing we can do upon discovering such request inside
    driver's ->do_request method is to just BUG().

In previous kernels the code would not dump, but still fail and print the 
request flags, identified by "ide_do_rw_disk - bad command", to the kernel 
log.
Manty: Have you ever seen such messages with previous kernels?

Question for IDE maintainers: should maybe the old printing of request info 
be reinstated, or can the request flags also be obtained from the BUG 
info?

Cheers,
FJP

  reply	other threads:[~2009-10-01  8:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30 11:05 kernel BUG at drivers/ide/ide-disk.c:187 (2.6.31) Santiago Garcia Mantinan
2009-10-01  6:57 ` Andrew Morton
2009-10-01  8:26   ` Frans Pop [this message]
2009-10-01  8:30     ` David Miller
2009-10-01  9:25       ` Bartlomiej Zolnierkiewicz
2009-10-01 16:40         ` David Miller
2009-10-01 18:21           ` Bartlomiej Zolnierkiewicz
2009-10-01 18:34             ` David Miller
2009-10-01 18:52               ` Bartlomiej Zolnierkiewicz
2009-10-01 10:11     ` Santiago Garcia Mantinan
2009-10-01 18:47 ` David Miller
2009-10-01 18:53   ` David Miller
2009-10-03  3:39     ` Santiago Garcia Mantinan
2009-10-04 22:37       ` Santiago Garcia Mantinan
2009-10-05  0:19         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910011026.17510.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=akpm@linux-foundation.org \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manty@manty.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.