From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Andrew Sharp <andy.sharp@lsi.com>,
Thomas Hommel <thomas.hommel@gefanuc.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] rtc-ds1511: Fix races around device registration
Date: Mon, 12 Oct 2009 18:47:39 +0200 [thread overview]
Message-ID: <20091012184739.46bb1052@i1501.lan.towertech.it> (raw)
In-Reply-To: <1255365461-5732-1-git-send-email-anemo@mba.ocn.ne.jp>
On Tue, 13 Oct 2009 01:37:40 +0900
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> * Call dev_set_drvdata before rtc device creation
> * Use its own spinlock instead of rtc->irq_lock
why?
> * Check pdata->rtc before calling rtc_update_irq
> * Use {alarm,update}_irq_enable and remove ioctl routine
> * Use devres APIs and simplify error/remove path
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2009-10-12 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 16:37 [PATCH 1/2] rtc-ds1511: Fix races around device registration Atsushi Nemoto
2009-10-12 16:47 ` Alessandro Zummo [this message]
2009-10-12 17:04 ` Atsushi Nemoto
-- strict thread matches above, loose matches on Subject: below --
2009-10-11 17:50 Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012184739.46bb1052@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=andy.sharp@lsi.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=thomas.hommel@gefanuc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.