From: "Michael S. Tsirkin" <mst@redhat.com> To: Avi Kivity <avi@redhat.com> Cc: Mark McLoughlin <markmc@redhat.com>, Dustin Kirkland <kirkland@canonical.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Anthony Liguori <anthony@codemonkey.ws>, Scott Tsai <scottt.tw@gmail.com> Subject: Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 17:03:47 +0200 [thread overview] Message-ID: <20091029150347.GA4913@redhat.com> (raw) In-Reply-To: <4AE9A8DE.1070609@redhat.com> On Thu, Oct 29, 2009 at 04:38:22PM +0200, Avi Kivity wrote: > On 10/29/2009 02:23 PM, Michael S. Tsirkin wrote: >> On Thu, Oct 29, 2009 at 09:16:43AM +0000, Mark McLoughlin wrote: >> >>> I agree we shouldn't exit in this scenario >>> >> virtio in qemu generally seems to handle guest errors >> by calling exit(2). This probably makes it easier to notice >> the problems, but is likely not the right thing to do. >> > > Right, the thinking was the guest is shooting itself in the foot and > hitting, but a guest can delegate control of a device to unprivileged > code (for example device assignment in kvm), When we emulate iommu, yes. > which would allow this unprivileged code to kill the guest. With usb emulation, we can have: drivers/usb/class/usblp.c:343:static const char *usblp_messages[] = { "ok", "out of paper", "off-line", "on fire" }; > -- > error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Avi Kivity <avi@redhat.com> Cc: Mark McLoughlin <markmc@redhat.com>, Scott Tsai <scottt.tw@gmail.com>, kvm@vger.kernel.org, Dustin Kirkland <kirkland@canonical.com>, qemu-devel@nongnu.org Subject: [Qemu-devel] Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 17:03:47 +0200 [thread overview] Message-ID: <20091029150347.GA4913@redhat.com> (raw) In-Reply-To: <4AE9A8DE.1070609@redhat.com> On Thu, Oct 29, 2009 at 04:38:22PM +0200, Avi Kivity wrote: > On 10/29/2009 02:23 PM, Michael S. Tsirkin wrote: >> On Thu, Oct 29, 2009 at 09:16:43AM +0000, Mark McLoughlin wrote: >> >>> I agree we shouldn't exit in this scenario >>> >> virtio in qemu generally seems to handle guest errors >> by calling exit(2). This probably makes it easier to notice >> the problems, but is likely not the right thing to do. >> > > Right, the thinking was the guest is shooting itself in the foot and > hitting, but a guest can delegate control of a device to unprivileged > code (for example device assignment in kvm), When we emulate iommu, yes. > which would allow this unprivileged code to kill the guest. With usb emulation, we can have: drivers/usb/class/usblp.c:343:static const char *usblp_messages[] = { "ok", "out of paper", "off-line", "on fire" }; > -- > error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-10-29 15:06 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-10-28 19:22 qemu-kvm-0.11 regression, crashes on older guests with virtio network Dustin Kirkland 2009-10-28 19:22 ` [Qemu-devel] " Dustin Kirkland 2009-10-28 19:29 ` Dustin Kirkland 2009-10-28 19:29 ` [Qemu-devel] " Dustin Kirkland 2009-10-29 3:12 ` [Qemu-devel] " Scott Tsai 2009-10-29 3:12 ` Scott Tsai 2009-10-29 9:16 ` Mark McLoughlin 2009-10-29 9:16 ` Mark McLoughlin 2009-10-29 12:00 ` Scott Tsai 2009-10-29 12:00 ` Scott Tsai 2009-10-29 12:16 ` Mark McLoughlin 2009-10-29 12:16 ` Mark McLoughlin 2009-10-29 12:21 ` Scott Tsai 2009-10-29 12:21 ` Scott Tsai 2009-10-29 14:11 ` Anthony Liguori 2009-10-29 14:11 ` Anthony Liguori 2009-10-29 14:25 ` Mark McLoughlin 2009-10-29 14:25 ` Mark McLoughlin 2009-10-29 14:34 ` Dustin Kirkland 2009-10-29 14:34 ` Dustin Kirkland 2009-10-29 14:46 ` Dustin Kirkland 2009-10-29 14:46 ` Dustin Kirkland 2009-10-29 14:50 ` Mark McLoughlin 2009-10-29 14:50 ` Mark McLoughlin 2009-10-29 14:39 ` Anthony Liguori 2009-10-29 14:39 ` Anthony Liguori 2009-10-29 14:48 ` Mark McLoughlin 2009-10-29 14:48 ` Mark McLoughlin 2009-10-29 15:01 ` Dustin Kirkland 2009-10-29 15:01 ` Dustin Kirkland 2009-10-29 15:01 ` Mark McLoughlin 2009-10-29 15:01 ` Mark McLoughlin 2009-10-29 15:13 ` Dustin Kirkland 2009-10-29 15:13 ` Dustin Kirkland 2009-10-29 15:15 ` Mark McLoughlin 2009-10-29 15:15 ` Mark McLoughlin 2009-10-29 15:34 ` [PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...] Dustin Kirkland 2009-10-29 15:34 ` [Qemu-devel] " Dustin Kirkland 2009-10-30 21:15 ` Dustin Kirkland 2009-10-30 21:15 ` [Qemu-devel] " Dustin Kirkland 2009-11-02 14:38 ` Mark McLoughlin 2009-11-02 14:38 ` [Qemu-devel] " Mark McLoughlin 2009-11-02 15:42 ` Anthony Liguori 2009-11-02 15:42 ` [Qemu-devel] " Anthony Liguori 2009-11-02 15:52 ` Jamie Lokier 2009-11-02 18:20 ` Michael Tokarev 2009-11-02 18:20 ` Michael Tokarev 2009-11-02 19:39 ` Jamie Lokier 2009-11-02 19:39 ` Jamie Lokier 2009-11-02 18:55 ` Anthony Liguori 2009-11-02 19:25 ` Dustin Kirkland 2009-11-02 19:25 ` Dustin Kirkland 2009-11-02 20:50 ` Anthony Liguori 2009-11-02 20:50 ` Anthony Liguori 2009-11-05 5:06 ` Jamie Lokier 2009-11-05 5:06 ` Jamie Lokier 2009-11-02 16:58 ` Dustin Kirkland 2009-11-02 16:58 ` [Qemu-devel] " Dustin Kirkland 2009-10-29 14:39 ` [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network Dustin Kirkland 2009-10-29 14:39 ` Dustin Kirkland 2009-10-29 23:22 ` Scott Tsai 2009-10-29 23:22 ` Scott Tsai 2009-10-29 12:23 ` Michael S. Tsirkin 2009-10-29 12:23 ` [Qemu-devel] " Michael S. Tsirkin 2009-10-29 14:38 ` Avi Kivity 2009-10-29 14:38 ` [Qemu-devel] " Avi Kivity 2009-10-29 15:03 ` Michael S. Tsirkin [this message] 2009-10-29 15:03 ` Michael S. Tsirkin 2009-10-29 14:43 ` [Qemu-devel] " Dustin Kirkland 2009-10-29 14:43 ` Dustin Kirkland
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091029150347.GA4913@redhat.com \ --to=mst@redhat.com \ --cc=anthony@codemonkey.ws \ --cc=avi@redhat.com \ --cc=kirkland@canonical.com \ --cc=kvm@vger.kernel.org \ --cc=markmc@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=scottt.tw@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.