All of lore.kernel.org
 help / color / mirror / Atom feed
* S3C64XX DSP support added
@ 2009-11-02  2:09 jassisinghbrar
  2009-11-02 10:42 ` Mark Brown
  0 siblings, 1 reply; 10+ messages in thread
From: jassisinghbrar @ 2009-11-02  2:09 UTC (permalink / raw)
  To: linux-samsung-soc; +Cc: Jassi Brar

From: Jassi Brar <jassi.brar@samsung.com>

next coming are patches for review before I submit them mainline.
thanks.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: S3C64XX DSP support added
  2009-11-02  2:09 S3C64XX DSP support added jassisinghbrar
@ 2009-11-02 10:42 ` Mark Brown
  2009-11-02 11:10   ` jassi brar
  0 siblings, 1 reply; 10+ messages in thread
From: Mark Brown @ 2009-11-02 10:42 UTC (permalink / raw)
  To: jassisinghbrar; +Cc: linux-samsung-soc, Jassi Brar

On Mon, Nov 02, 2009 at 11:09:34AM +0900, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
> 
> next coming are patches for review before I submit them mainline.
> thanks.

If nothing else these need a better name - the name suggests that
they're a DSP when in fact they are actually implementing support for
the PCM interface.  You might want to rename the existing PCM driver to
DMA.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: S3C64XX DSP support added
  2009-11-02 10:42 ` Mark Brown
@ 2009-11-02 11:10   ` jassi brar
  2009-11-02 11:23     ` Mark Brown
  0 siblings, 1 reply; 10+ messages in thread
From: jassi brar @ 2009-11-02 11:10 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-samsung-soc, Jassi Brar

On Mon, Nov 2, 2009 at 7:42 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Nov 02, 2009 at 11:09:34AM +0900, jassisinghbrar@gmail.com wrote:
>> From: Jassi Brar <jassi.brar@samsung.com>
>>
>> next coming are patches for review before I submit them mainline.
>> thanks.
>
> If nothing else these need a better name - the name suggests that
> they're a DSP when in fact they are actually implementing support for
> the PCM interface.

I saw that coming...
The codec drivers use the term DSP (DSP_A/DSP_B) for what our PCM
controller does.
I used 'DSP' for things related to ALSA and 'PCM' for h/w specific things.

> You might want to rename the existing PCM driver to DMA.
Could do that, but still 'PCM' is used at other places in the stack as well.
Would that be fine?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: S3C64XX DSP support added
  2009-11-02 11:10   ` jassi brar
@ 2009-11-02 11:23     ` Mark Brown
  2009-11-02 11:59       ` jassi brar
  0 siblings, 1 reply; 10+ messages in thread
From: Mark Brown @ 2009-11-02 11:23 UTC (permalink / raw)
  To: jassi brar; +Cc: linux-samsung-soc, Jassi Brar

On Mon, Nov 02, 2009 at 08:10:07PM +0900, jassi brar wrote:

> The codec drivers use the term DSP (DSP_A/DSP_B) for what our PCM
> controller does.

I know; this is a bit unfortunate but not too much of an issue since
it's only ever mentioned in the context of a DAIFMT constant so it's
clear what's being talked about.  In this case it's particularly
confusing because the hardware is always talked about as being PCM and
from the sounds of it some of the current S5P processors already have
some basic DSP stuff in them.

> I used 'DSP' for things related to ALSA and 'PCM' for h/w specific things.

I'm having a hard time following your logic here?  This is a hardware
driver after all.

> > You might want to rename the existing PCM driver to DMA.
> Could do that, but still 'PCM' is used at other places in the stack as well.
> Would that be fine?

Probably, yes.  The use of PCM for DMA drivers is there mostly because
in older systems the PCM interface offered no software control at all so
all you needed to drive them was the DMA driver.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: S3C64XX DSP support added
  2009-11-02 11:23     ` Mark Brown
@ 2009-11-02 11:59       ` jassi brar
  2009-11-02 12:07         ` Mark Brown
  0 siblings, 1 reply; 10+ messages in thread
From: jassi brar @ 2009-11-02 11:59 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-samsung-soc, Jassi Brar

On Mon, Nov 2, 2009 at 8:23 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Nov 02, 2009 at 08:10:07PM +0900, jassi brar wrote:

>> I used 'DSP' for things related to ALSA and 'PCM' for h/w specific things.
>
> I'm having a hard time following your logic here?  This is a hardware
> driver after all.
Register and bit definitions, DMA and other platform resources are all
using 'PCM',
while ALSA related stuff : CPU driver, DAI name etc are using 'DSP'.

>> > You might want to rename the existing PCM driver to DMA.
>> Could do that, but still 'PCM' is used at other places in the stack as well.
>> Would that be fine?
>
> Probably, yes.  The use of PCM for DMA drivers is there mostly because
> in older systems the PCM interface offered no software control at all so
> all you needed to drive them was the DMA driver.
Okay, will rename s3c24xx-pcm.c to s3c24xx-dma.c and call this driver
as s3c64xx-pcm.c

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: S3C64XX DSP support added
  2009-11-02 11:59       ` jassi brar
@ 2009-11-02 12:07         ` Mark Brown
  2009-11-03  1:38           ` jassi brar
  0 siblings, 1 reply; 10+ messages in thread
From: Mark Brown @ 2009-11-02 12:07 UTC (permalink / raw)
  To: jassi brar; +Cc: linux-samsung-soc, Jassi Brar

On Mon, Nov 02, 2009 at 08:59:44PM +0900, jassi brar wrote:

> Okay, will rename s3c24xx-pcm.c to s3c24xx-dma.c and call this driver
> as s3c64xx-pcm.c

Is there a PCM controller on the s3c24xx chips?  I know you're not
particularly intersted in them but if there is I'd be surprised if the
same driver wouldn't work for both and someone else might want to add
the s3c24xx specific stuff (probably mostly under arch/arm).  If that is
the case then s3c-pcm might be better.

It'd be nice to do that for the DMA driver too if it is getting renamed
anyway.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: S3C64XX DSP support added
  2009-11-02 12:07         ` Mark Brown
@ 2009-11-03  1:38           ` jassi brar
  2009-11-03  9:47             ` Mark Brown
  0 siblings, 1 reply; 10+ messages in thread
From: jassi brar @ 2009-11-03  1:38 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-samsung-soc, Jassi Brar

On Mon, Nov 2, 2009 at 9:07 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Nov 02, 2009 at 08:59:44PM +0900, jassi brar wrote:
>
>> Okay, will rename s3c24xx-pcm.c to s3c24xx-dma.c and call this driver
>> as s3c64xx-pcm.c
>
> Is there a PCM controller on the s3c24xx chips?  I know you're not
> particularly intersted in them but if there is I'd be surprised if the
> same driver wouldn't work for both and someone else might want to add
> the s3c24xx specific stuff (probably mostly under arch/arm).  If that is
> the case then s3c-pcm might be better.
Only s3c2450 in the 24xx series have a pcm controller. Since there is
no support for s3c2450 in mainline, I had to make it for s3c64xx

> It'd be nice to do that for the DMA driver too if it is getting renamed
> anyway.
okay.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: S3C64XX DSP support added
  2009-11-03  1:38           ` jassi brar
@ 2009-11-03  9:47             ` Mark Brown
  2009-11-03 11:58               ` jassi brar
  0 siblings, 1 reply; 10+ messages in thread
From: Mark Brown @ 2009-11-03  9:47 UTC (permalink / raw)
  To: jassi brar; +Cc: linux-samsung-soc, Jassi Brar

On Tue, Nov 03, 2009 at 10:38:47AM +0900, jassi brar wrote:
> On Mon, Nov 2, 2009 at 9:07 PM, Mark Brown

> > Is there a PCM controller on the s3c24xx chips?  I know you're not

> Only s3c2450 in the 24xx series have a pcm controller. Since there is
> no support for s3c2450 in mainline, I had to make it for s3c64xx

In that case the s3c- name would be nice in case someone does submit
support for that CPU some time.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: S3C64XX DSP support added
  2009-11-03  9:47             ` Mark Brown
@ 2009-11-03 11:58               ` jassi brar
  2009-11-03 12:02                 ` Mark Brown
  0 siblings, 1 reply; 10+ messages in thread
From: jassi brar @ 2009-11-03 11:58 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-samsung-soc, Jassi Brar

On Tue, Nov 3, 2009 at 6:47 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Nov 03, 2009 at 10:38:47AM +0900, jassi brar wrote:
>> On Mon, Nov 2, 2009 at 9:07 PM, Mark Brown
>
>> > Is there a PCM controller on the s3c24xx chips?  I know you're not
>
>> Only s3c2450 in the 24xx series have a pcm controller. Since there is
>> no support for s3c2450 in mainline, I had to make it for s3c64xx
>
> In that case the s3c- name would be nice in case someone does submit
> support for that CPU some time.
Okay, will do that. thanks

btw, I plan to rename s3c24xx-pcm.c/h to s3c-audio.c/h rather than s3c-dma.c/h
because that code isn't about just dma and s3c-dma doesn't sound anything audio
related.
Also, the prefix s3c24xx_pcm_* in s3c24xx-pcm.c has been changed to s3c_audio_*

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: S3C64XX DSP support added
  2009-11-03 11:58               ` jassi brar
@ 2009-11-03 12:02                 ` Mark Brown
  0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2009-11-03 12:02 UTC (permalink / raw)
  To: jassi brar; +Cc: linux-samsung-soc, Jassi Brar

On Tue, Nov 03, 2009 at 08:58:22PM +0900, jassi brar wrote:

> btw, I plan to rename s3c24xx-pcm.c/h to s3c-audio.c/h rather than s3c-dma.c/h
> because that code isn't about just dma and s3c-dma doesn't sound anything audio

The fact that it's in sound/soc ought to be a pretty big hint that it's
audio...

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2009-11-03 12:02 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-02  2:09 S3C64XX DSP support added jassisinghbrar
2009-11-02 10:42 ` Mark Brown
2009-11-02 11:10   ` jassi brar
2009-11-02 11:23     ` Mark Brown
2009-11-02 11:59       ` jassi brar
2009-11-02 12:07         ` Mark Brown
2009-11-03  1:38           ` jassi brar
2009-11-03  9:47             ` Mark Brown
2009-11-03 11:58               ` jassi brar
2009-11-03 12:02                 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.