All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sebastian Dalfuß" <sd@sedf.de>
To: greg@kroah.com
Cc: linux-kernel@vger.kernel.org
Subject: [Patch 3/3 v2] staging: rt2860: reduce superfluous exclamation marks
Date: Fri, 6 Nov 2009 14:48:12 +0100	[thread overview]
Message-ID: <20091106134812.GA27210@sedf.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 5171 bytes --]

From: Sebastian Dalfuß <sd@sedf.de>

This patch is based on next-20091106.
This patch reduces the number of exclamation marks in DBGPRINT() and
printk() strings (also comments) to a slightly less insane number.

Signed-off-by: Sebastian Dalfuß <sd@sedf.de>
---
diff -ru b/drivers/staging/rt2860/common/cmm_data.c c/drivers/staging/rt2860/common/cmm_data.c
--- b/drivers/staging/rt2860/common/cmm_data.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/common/cmm_data.c	2009-11-06 12:04:42.201639959 +0100
@@ -1729,7 +1729,7 @@
 				  pAd->MacTab.Size));
 		} else {
 			DBGPRINT(RT_DEBUG_OFF,
-				 ("\n%s: Impossible Wcid = %d !!!!!\n",
+				 ("\n%s: Impossible Wcid = %d !!!\n",
 				  __func__, wcid));
 		}
 	}
diff -ru b/drivers/staging/rt2860/common/mlme.c c/drivers/staging/rt2860/common/mlme.c
--- b/drivers/staging/rt2860/common/mlme.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/common/mlme.c	2009-11-06 12:04:42.431640138 +0100
@@ -4600,7 +4600,7 @@
  * input params:
  *		Buffer - pointer to a pre-allocated memory segment
  *		args - a list of <int arg_size, arg> pairs.
- *		NOTE NOTE NOTE!!!! the last argument must be NULL, otherwise this
+ *		NOTE NOTE NOTE!!! the last argument must be NULL, otherwise this
  *						   function will FAIL!!!
  * return:
  *		Size of the buffer
diff -ru b/drivers/staging/rt2860/rtmp_def.h c/drivers/staging/rt2860/rtmp_def.h
--- b/drivers/staging/rt2860/rtmp_def.h	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/rtmp_def.h	2009-11-06 12:04:42.614973444 +0100
@@ -409,7 +409,7 @@
 #define MAX_LEN_OF_MAC_TABLE            MAX_NUMBER_OF_MAC	/* if MAX_MBSSID_NUM is 8, this value can't be larger than 211 */
 
 #if MAX_LEN_OF_MAC_TABLE>MAX_AVAILABLE_CLIENT_WCID
-#error MAX_LEN_OF_MAC_TABLE can not be larger than MAX_AVAILABLE_CLIENT_WCID!!!!
+#error MAX_LEN_OF_MAC_TABLE can not be larger than MAX_AVAILABLE_CLIENT_WCID!!!
 #endif
 
 #define MAX_NUM_OF_WDS_LINK_PERBSSID	            3
diff -ru b/drivers/staging/rt2860/sta/assoc.c c/drivers/staging/rt2860/sta/assoc.c
--- b/drivers/staging/rt2860/sta/assoc.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/sta/assoc.c	2009-11-06 12:04:42.714973141 +0100
@@ -563,7 +563,7 @@
 		pAd->Mlme.AssocMachine.CurrState = ASSOC_WAIT_RSP;
 	} else {
 		DBGPRINT(RT_DEBUG_TRACE,
-			 ("ASSOC - MlmeAssocReqAction() sanity check failed. BUG!!!!!! \n"));
+			 ("ASSOC - MlmeAssocReqAction() sanity check failed. BUG!!! \n"));
 		pAd->Mlme.AssocMachine.CurrState = ASSOC_IDLE;
 		Status = MLME_INVALID_FORMAT;
 		MlmeEnqueue(pAd, MLME_CNTL_STATE_MACHINE, MT2_ASSOC_CONF, 2,
@@ -746,7 +746,7 @@
 		pAd->Mlme.AssocMachine.CurrState = REASSOC_WAIT_RSP;
 	} else {
 		DBGPRINT(RT_DEBUG_TRACE,
-			 ("ASSOC - MlmeReassocReqAction() sanity check failed. BUG!!!! \n"));
+			 ("ASSOC - MlmeReassocReqAction() sanity check failed. BUG!!! \n"));
 		pAd->Mlme.AssocMachine.CurrState = ASSOC_IDLE;
 		Status = MLME_INVALID_FORMAT;
 		MlmeEnqueue(pAd, MLME_CNTL_STATE_MACHINE, MT2_REASSOC_CONF, 2,
diff -ru b/drivers/staging/rt2860/sta/connect.c c/drivers/staging/rt2860/sta/connect.c
--- b/drivers/staging/rt2860/sta/connect.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/sta/connect.c	2009-11-06 12:04:42.751640132 +0100
@@ -911,7 +911,7 @@
 				  pAd->CommonCfg.Bssid[5]));
 		} else {
 			DBGPRINT(RT_DEBUG_TRACE,
-				 ("CNTL - Start IBSS fail. BUG!!!!!\n"));
+				 ("CNTL - Start IBSS fail. BUG!!!\n"));
 			pAd->Mlme.CntlMachine.CurrState = CNTL_IDLE;
 		}
 	}
diff -ru b/drivers/staging/rt2860/sta/rtmp_data.c c/drivers/staging/rt2860/sta/rtmp_data.c
--- b/drivers/staging/rt2860/sta/rtmp_data.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/sta/rtmp_data.c	2009-11-06 12:04:42.808307173 +0100
@@ -1680,7 +1680,7 @@
 
 		pMacEntry = pTxBlk->pMacEntry;
 		if (pMacEntry->isCached) {
-			/* NOTE: Please make sure the size of pMacEntry->CachedBuf[] is smaller than pTxBlk->HeaderBuf[]!!!! */
+			/* NOTE: Please make sure the size of pMacEntry->CachedBuf[] is smaller than pTxBlk->HeaderBuf[]!!! */
 			NdisMoveMemory((u8 *)& pTxBlk->
 				       HeaderBuf[TXINFO_SIZE],
 				       (u8 *)& pMacEntry->CachedBuf[0],
diff -ru b/drivers/staging/rt2860/usb_main_dev.c c/drivers/staging/rt2860/usb_main_dev.c
--- b/drivers/staging/rt2860/usb_main_dev.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/usb_main_dev.c	2009-11-06 12:04:42.851640100 +0100
@@ -584,7 +584,7 @@
 	RTMP_IO_READ32(pAd, TXRXQ_PCNT, &MACValue);
 	if ((MACValue & 0xff) != 0) {
 		DBGPRINT(RT_DEBUG_TRACE,
-			 ("TX QUEUE 0 Not EMPTY(Value=0x%0x). !!!!!!!!!!!!!!!\n",
+			 ("TX QUEUE 0 Not EMPTY(Value=0x%0x). !!!\n",
 			  MACValue));
 		RTMP_IO_WRITE32(pAd, PBF_CFG, 0xf40012);
 		while ((MACValue & 0xff) != 0 && (idx++ < 10)) {
@@ -707,7 +707,7 @@
 					}
 				} else {
 					DBGPRINT(RT_DEBUG_ERROR,
-						 ("Unkonw bulkOut URB maybe hanged!!!!!!!!!!!!\n"));
+						 ("Unknown bulkOut URB maybe hanged!!!\n"));
 				}
 			} else {
 				RTMP_IRQ_UNLOCK(&pAd->BulkOutLock[idx],


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

             reply	other threads:[~2009-11-06 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-06 13:48 Sebastian Dalfuß [this message]
2009-11-06 22:59 ` [Patch 3/3 v2] staging: rt2860: reduce superfluous exclamation marks Greg KH
2009-11-07 16:31   ` Sebastian Dalfuß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091106134812.GA27210@sedf.de \
    --to=sd@sedf.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.