From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752742AbZKGTOL (ORCPT ); Sat, 7 Nov 2009 14:14:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751800AbZKGTOH (ORCPT ); Sat, 7 Nov 2009 14:14:07 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:56991 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbZKGTOH (ORCPT ); Sat, 7 Nov 2009 14:14:07 -0500 Date: Sat, 7 Nov 2009 20:14:05 +0100 From: Pavel Machek To: "Rafael J. Wysocki" Cc: Thomas Gleixner , LKML , Thierry Vignaud , bugzilla-daemon@bugzilla.kernel.org Subject: Re: [Bug 14537] New: missing compat_ioctl on x86_64 Message-ID: <20091107191405.GD5361@elf.ucw.cz> References: <200911042312.52116.rjw@sisk.pl> <20091107172038.GA1835@ucw.cz> <200911072006.36904.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200911072006.36904.rjw@sisk.pl> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > > > > - when trying to suspend: > > > > > ioctl32(s2disk:8164): Unknown cmd fd(4) cmd(400c330d){t:'3';sz:12} > > > > > arg(ffc190ec) on /dev/snapshot > > > > > ioctl32(s2disk:8164): Unknown cmd fd(4) cmd(4004330a){t:'3';sz:4} arg(00000806) > > > > > on /dev/snapshot > > > > > > > > snapshot_ioctl seems to lack compat support completely. Raphael ?? > > > > > > It does, but that wouldn't work anyway. s2disk is one of the things that have > > > to be native. > > > > Actually... it would be nice to fix that one day, if someone submitted > > nice patch... :-). > > It must be fixed in s2disk first, but that would probably require us to drop > support for older kernels. Which is not unthinkable, but might hurt some > users. It should be possible to check compat_task() and provide interface userland expects. But yes, improving interface to be same for 32 and 64bit would probably be the way, too. (Or did you have something else in mind?) Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html