Re: [PATCH v3] x86: under bios control, restore AP's APIC_LVTTHMR to the BSP value

From: Ingo Molnar <mingo@elte.hu>
To: Yong Wang <yong.y.wang@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	Arjan van de Ven <arjan@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] x86: under bios control, restore AP's APIC_LVTTHMR to the BSP value
Date: Mon, 9 Nov 2009 08:08:44 +0100	[thread overview]
Message-ID: <20091109070844.GA453@elte.hu> (raw)
In-Reply-To: <20091109042134.GA9169@ywang-moblin2.bj.intel.com>

* Yong Wang <yong.y.wang@linux.intel.com> wrote:

> Changes since v2:
> Incorporate Ingo's comments to get BSP's thermal init value in a
> 'boot-CPU-only' function.

> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index e09f0e2..2323771 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -1002,6 +1002,7 @@ void __init setup_arch(char **cmdline_p)
>  
>  	init_apic_mappings();
>  	ioapic_init_mappings();
> +	get_bsp_lvtthmr_init();
>  
>  	/* need to wait for io_apic is mapped */
>  	probe_nr_irqs_gsi();

Ok - it's almost good in this form - it would be nice to name the new 
function something more generic, like mcheck_intel_therm_init(), and 
call it from arch/x86/kernel/cpu/mcheck/mce.c's mcheck_init() function.

Thanks,

	Ingo