From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754768AbZKIJGS@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754768AbZKIJGS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Nov 2009 04:06:18 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754503AbZKIJGR
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 9 Nov 2009 04:06:17 -0500
Received: from mx3.mail.elte.hu ([157.181.1.138]:40531 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754668AbZKIJGQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Nov 2009 04:06:16 -0500
Date: Mon, 9 Nov 2009 10:06:07 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Yong Wang <yong.y.wang@linux.intel.com>
Cc: Borislav Petkov <borislav.petkov@amd.com>,
       "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
       Suresh Siddha <suresh.b.siddha@intel.com>,
       Arjan van de Ven <arjan@infradead.org>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] x86: under bios control, restore AP's APIC_LVTTHMR to
 the BSP value
Message-ID: <20091109090607.GB19000@elte.hu>
References: <20091109042134.GA9169@ywang-moblin2.bj.intel.com>
 <20091109070844.GA453@elte.hu>
 <20091109072528.GA2646@ywang-moblin2.bj.intel.com>
 <20091109075957.GH453@elte.hu>
 <20091109083146.GA3484@ywang-moblin2.bj.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091109083146.GA3484@ywang-moblin2.bj.intel.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
X-ELTE-SpamScore: -1.5
X-ELTE-SpamLevel: 
X-ELTE-SpamCheck: no
X-ELTE-SpamVersion: ELTE 2.0 
X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5
	-1.5 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Yong Wang <yong.y.wang@linux.intel.com> wrote:

> On Mon, Nov 09, 2009 at 08:59:57AM +0100, Ingo Molnar wrote:
> > 
> > That's true in Linus's tree but Boris Petkov fixed the MCE init 
> > functions naming mess in the x86 tree, in these commits:
> > 
> >  b33a636: x86, mce: Add a global MCE init helper
> >  5e09954: x86, mce: Fix up MCE naming nomenclature
> > 
> > Please base your patch on:
> > 
> >   http://people.redhat.com/mingo/tip.git/README
> > 
> > to have the latest MCE code. So if you stick that init function into 
> > mcheck_init() in -tip it should be called once per bootup only. (I have 
> > not checked the other boot dependencies, please do that.)
> 
> By the time mcheck_init() executes, intel_init_thermal() has finished 
> running on BSP. Any suggestions on how to resolve this issue?

it's an early_initcall() right now - if that's not early enough then 
please call it explicitly from setup.c like you did it with the thermal 
init function from your previous patch. (and remove the early_initcall() 
line)

	Ingo