From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH V2] ASoC - Add support for upto 16 channels on OMAP MCBSP Date: Mon, 9 Nov 2009 09:47:32 +0200 Message-ID: <20091109094732.a5fcb6ef.jhnikula@gmail.com> References: <1257454808.3576.397.camel@odin> <6ed0b2680911071211g311e6399va88ff7daff7b8ed1@mail.gmail.com> <1257712022.15162.2.camel@vega> <200911090929.02019.peter.ujfalusi@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f217.google.com (mail-bw0-f217.google.com [209.85.218.217]) by alsa0.perex.cz (Postfix) with ESMTP id BDD691038BA for ; Mon, 9 Nov 2009 08:46:39 +0100 (CET) Received: by bwz9 with SMTP id 9so11997839bwz.32 for ; Sun, 08 Nov 2009 23:46:39 -0800 (PST) In-Reply-To: <200911090929.02019.peter.ujfalusi@nokia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Ujfalusi Cc: Graeme Gregory , alsa-devel@alsa-project.org, Mark Brown , Grazvydas Ignotas , ext Liam Girdwood List-Id: alsa-devel@alsa-project.org On Mon, 9 Nov 2009 09:29:01 +0200 Peter Ujfalusi wrote: > So this patch definitely breaks McBSP slave mode. > In case when McBSP is slave, the SRG is not in use, and there is no point of > passing some bogus information in order to pass the test in > omap_mcbsp_dai_hw_params introduced by this patch. > > I think if I set the mcbsp_data->in_freq to be: > params_rate(params) * sample_bits * channels, and configure the mcbsp_data- > >clk_div to be 1, might work in this case. > > But after this patch the beagle board and boards which has the McBSP as slave > will stop working. > > I'm afraid, I can not give my Ack for this :( > Big thanks Peter! Me either. How on earth I didn't notice or test this simple thing that framesize calculatation leads to zero for all other boards than Pandora... and working Beagle audio is *must* have feature for me... -- Jarkko