From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/4] add interface property to primary context
Date: Mon, 09 Nov 2009 10:57:15 -0600 [thread overview]
Message-ID: <200911091057.16388.denkenz@gmail.com> (raw)
In-Reply-To: <1257752281-22251-1-git-send-email-martin.xu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
Hi Martin,
> @@ -37,6 +37,7 @@ struct ofono_gprs_context;
> struct ofono_gprs_primary_context {
> unsigned int cid;
> int direction;
> + char *interface;
> char apn[OFONO_GPRS_MAX_APN_LENGTH + 1];
> char username[OFONO_GPRS_MAX_USERNAME_LENGTH + 1];
> char password[OFONO_GPRS_MAX_PASSWORD_LENGTH + 1];
Logically this does not belong here. It should be added to
ofono_gprs_context, or perhaps to pri_context.
Regards,
-Denis
prev parent reply other threads:[~2009-11-09 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 7:37 [PATCH 1/4] add interface property to primary context Martin Xu
2009-11-09 7:37 ` [PATCH 2/4] add create/destroy_interface to ofono_gprs_context_driver Martin Xu
2009-11-09 7:38 ` [PATCH 3/4] add function ofono_gprs_context_get_modem Martin Xu
2009-11-09 7:38 ` [PATCH 4/4] add mbm_gprs_create/destroy_interface to mbm gprs_context_driver Martin Xu
2009-11-09 16:59 ` [PATCH 2/4] add create/destroy_interface to ofono_gprs_context_driver Denis Kenzior
2009-11-09 7:42 ` [PATCH */4] add interface property to primary context Xu, Martin
2009-11-10 3:28 ` How does ConnMan works with Ofono? " Xu, Martin
2009-11-10 4:52 ` Xu, Martin
2009-11-09 16:57 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911091057.16388.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.