All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT]: IDE
Date: Mon, 9 Nov 2009 11:35:08 +0100	[thread overview]
Message-ID: <200911091135.09051.bzolnier@gmail.com> (raw)
In-Reply-To: <20091108.213055.54434626.davem@davemloft.net>

On Monday 09 November 2009 06:30:55 David Miller wrote:
> 
> The revert we thought we didn't need, we really do need still, even
> with Bart Z.'s fix.
> 
> The issue is that we are doing these PIO setting calls before we did
> the device probe and therefore we don't yet know the media type.
> 
> Yet the ->set_pio_mode() of some drivers key off of the media type to
> determine whether to turn prefetching etc. on so it can't possibly
> work properly.

Thanks for quick reaction to the revert request.

If somebody is interested in the proper way to fix it you just need to
add ide_unknown media type and set it before probe instead of ide_disk
one.  Then audit ->set_pio_mode implementations for potential gotchas.

[ However it is too late for -rc and nobody is currently working on
  IDE fixes anyway so I just requested the revert . ]

-- 
Bartlomiej Zolnierkiewicz

  reply	other threads:[~2009-11-09 10:36 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09  5:30 [GIT]: IDE David Miller
2009-11-09 10:35 ` Bartlomiej Zolnierkiewicz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-04-06 18:24 [GIT] IDE David Miller
2020-04-07 19:55 ` pr-tracker-bot
2020-01-30 10:07 David Miller
2020-01-30 18:00 ` pr-tracker-bot
2019-07-13  6:17 [GIT] Ide David Miller
2019-07-13 23:15 ` pr-tracker-bot
2019-05-08 23:53 [GIT] IDE David Miller
2019-05-09  4:45 ` pr-tracker-bot
     [not found] ` <CGME20190510172236eucas1p138115389e72802f72e47158df6ed9871@eucas1p1.samsung.com>
2019-05-10 17:22   ` Bartlomiej Zolnierkiewicz
2019-03-11  5:00 David Miller
2019-03-11 17:50 ` pr-tracker-bot
2018-12-03  6:31 David Miller
2018-12-03 17:55 ` pr-tracker-bot
2018-08-22  5:17 David Miller
2018-06-09 14:20 David Miller
2018-02-01 15:32 David Miller
2017-11-19 12:43 David Miller
2017-07-21  3:40 David Miller
2017-05-09 20:04 David Miller
2017-02-28  1:50 David Miller
2016-07-29 17:57 David Miller
2016-03-28 19:45 David Miller
     [not found] <20160118.143241.1114572935099360375.davem@davemloft.net>
2016-01-18 19:33 ` David Miller
2015-11-03 21:44 David Miller
2015-04-17 20:14 David Miller
2015-03-19  4:59 David Miller
2014-12-12 21:00 David Miller
2014-10-15 18:44 David Miller
2014-08-06  5:03 David Miller
2014-07-22  5:37 David Miller
2014-01-29  8:50 David Miller
2013-11-14 23:29 David Miller
2013-09-05 20:44 David Miller
2013-07-10 19:21 David Miller
2012-06-15 22:42 David Miller
2011-11-18 19:47 David Miller
2011-10-03 19:35 David Miller
2011-08-05 10:28 David Miller
2011-06-12  5:32 David Miller
2011-05-23  4:58 David Miller
2010-10-29  3:45 David Miller
2010-09-18  4:19 David Miller
2010-09-18 12:01 ` Wolfram Sang
2010-08-09 10:28 David Miller
2010-05-24  7:11 David Miller
2010-04-08  8:36 David Miller
2010-04-08 15:02 ` Linus Torvalds
2010-04-08 18:15   ` David Miller
2010-03-28  2:29 [GIT]: IDE David Miller
2010-03-29  2:01 ` David Miller
2010-03-04  8:25 David Miller
2009-12-08 23:49 David Miller
2009-11-30  9:17 David Miller
2009-10-29 14:36 David Miller
2009-10-07 11:10 David Miller
2009-10-05 21:05 David Miller
2009-09-15  8:53 David Miller
2009-09-06 21:13 David Miller
2009-07-22  4:21 David Miller
2009-07-06 21:51 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911091135.09051.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.