All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Tarmigan <tarmigan+git@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2009, #02; Sun, 08)
Date: Mon, 9 Nov 2009 07:29:35 -0800	[thread overview]
Message-ID: <20091109152935.GM11919@spearce.org> (raw)
In-Reply-To: <905315640911090008h34b55a37q439d02de37127039@mail.gmail.com>

Tarmigan <tarmigan+git@gmail.com> wrote:
> On Sun, Nov 8, 2009 at 9:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > * sp/smart-http (2009-11-04) 30 commits
> >  + test smart http fetch and push
> 
> I am trying to test smart http, and have had to set
> DEFAULT_HTTPD_PATH='/usr/sbin/httpd'
> DEFAULT_HTTPD_MODULE_PATH='/usr/lib64/httpd/modules' on Centos.
> Perhaps this failing test is just a difference in the default Apache
> and curl configurations.

*sigh*
 
> --- exp	2009-11-09 07:33:19.000000000 +0000
> +++ act	2009-11-09 07:33:19.000000000 +0000
> @@ -6,15 +6,16 @@
>  < Pragma: no-cache
>  < Cache-Control: no-cache, max-age=0, must-revalidate
>  < Content-Type: application/x-git-upload-pack-advertisement
> -<
>  > POST /smart/repo.git/git-upload-pack HTTP/1.1
> +> Accept: */*
>  > Accept-Encoding: deflate, gzip
>  > Content-Type: application/x-git-upload-pack-request
>  > Accept: application/x-git-upload-pack-response

The first delta is a missing blank line between requests.  I probably
can work around that with some sort of sed hackery and its likely
caused by a different libcurl version.

The second delta is libcurl sending *two* Accept headers to the
server.  The first was set by the library as "*/*", but the second
was set by git-remote-curl.  Here your libcurl is just plain *wrong*.
The application has said "I only support one content type, this one"
and the library still went and told the server "I accept anything
you have, just give it to me!".

I'm not sure what to do about this breakage in curl.  We may have
to relax how we use HTTP since at least one version of libcurl
can't get this minor detail right.

>  > Content-Length: xxx
> 
> +> 0073want 1937bb05802e1973cc2e437c13e9f1845941b785
> multi_ack_detailed side-band-64k thin-pack no-progress ofs-delta
> +> 00000009done

Hmmph.  Your libcurl also included the POST body in the verbose
message.

-- 
Shawn.

  reply	other threads:[~2009-11-09 15:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09  5:18 What's cooking in git.git (Nov 2009, #02; Sun, 08) Junio C Hamano
2009-11-09  8:08 ` Tarmigan
2009-11-09 15:29   ` Shawn O. Pearce [this message]
2009-11-10 17:10 ` Tarmigan
2009-11-12  4:42   ` [PATCH] http-backend: Fix bad treatment of uintmax_t in Content-Length Shawn O. Pearce
2009-11-14 21:49     ` Tarmigan
2009-11-15  9:08       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091109152935.GM11919@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tarmigan+git@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.