All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	linux-kbuild@vger.kernel.org,
	Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [PATCH/RFC] fb: put framebuffer drivers back under the "frame buffer devices" menu
Date: Tue, 10 Nov 2009 16:51:14 -0800	[thread overview]
Message-ID: <20091110165114.4972b8b4.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0911082339090.24656@axis700.grange>

On Sun, 8 Nov 2009 23:46:24 +0100 (CET)
Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:

> The config FB_PRE_INIT_FB entry in drivers/video/Kconfig pushes all entries
> below it out of the menuconfig selection. Fix this.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> 
> This is _most_ _probably_ not a right fix, but rather an observation, that 
> the patch below fixes the problem, whereby all entires below 
> FB_PRE_INIT_FB get displaced from the "frame buffer devices" menu. A bug 
> in kconfig? The additional dependency on FB in this patch is certainly 
> redundant.
> 
>  drivers/video/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 9bbb285..188e1ba 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -2121,7 +2121,7 @@ config FB_EP93XX
>  
>  config FB_PRE_INIT_FB
>  	bool "Don't reinitialize, use bootloader's GDC/Display configuration"
> -	depends on FB_MB862XX_LIME
> +	depends on FB && FB_MB862XX_LIME
>  	---help---
>  	  Select this option if display contents should be inherited as set by
>  	  the bootloader.

hmm, well, lots of surrounding records also have `depends on FB', and
it fixes the bug, so I see no problem with using the patch as-is.


  reply	other threads:[~2009-11-11  0:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-08 22:46 [PATCH/RFC] fb: put framebuffer drivers back under the "frame buffer devices" menu Guennadi Liakhovetski
2009-11-11  0:51 ` Andrew Morton [this message]
2009-11-11  7:35   ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091110165114.4972b8b4.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.