From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: commit log encoding [Was: [PATCH 1/2] tree-wide: fix typos "offest" -> "offset"] Date: Wed, 11 Nov 2009 15:13:43 +0100 Message-ID: <20091111141342.GA1849@pengutronix.de> References: <1256757064-13669-1-git-send-email-u.kleine-koenig@pengutronix.de> <20091103081447.GA20204@pengutronix.de> <20091111114206.GA19652@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org To: Jiri Kosina X-From: git-owner@vger.kernel.org Wed Nov 11 15:13:54 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1N8DxJ-0006gL-Ks for gcvg-git-2@lo.gmane.org; Wed, 11 Nov 2009 15:13:53 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756661AbZKKONj convert rfc822-to-quoted-printable (ORCPT ); Wed, 11 Nov 2009 09:13:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756112AbZKKONi (ORCPT ); Wed, 11 Nov 2009 09:13:38 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:60935 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755695AbZKKONi (ORCPT ); Wed, 11 Nov 2009 09:13:38 -0500 Received: from octopus.hi.pengutronix.de ([2001:6f8:1178:2:215:17ff:fe12:23b0]) by metis.ext.pengutronix.de with esmtp (Exim 4.63) (envelope-from ) id 1N8Dx9-0003Wd-Dm; Wed, 11 Nov 2009 15:13:43 +0100 Received: from ukl by octopus.hi.pengutronix.de with local (Exim 4.69) (envelope-from ) id 1N8Dx9-0007MQ-2Q; Wed, 11 Nov 2009 15:13:43 +0100 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: git@vger.kernel.org Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Nov 11, 2009 at 01:19:32PM +0100, Jiri Kosina wrote: > On Wed, 11 Nov 2009, Uwe Kleine-K=C3=B6nig wrote: >=20 > > > Thanks for noticing, I had a bug in my git charset config for qui= te some=20 > > > time. Fixed it now. > > Now my name is latin1 encoded. It should be utf-8, doesn't it? >=20 > It's not latin1, it's iso-8859-2 =46or my name it makes no difference. > which is what I use on my terminals= =2E > And git can handle that fine too (it stores the encoding together wit= h the=20 > commit). Ah, OK, that's news to me, but you're right. I have here: ~/gsrc/linux-2.6$ git cat-file commit 30ff0743f88a70f52a4de5ea5bcb1fd2= 9bcfab2d tree 6121d35bb2606878be636e897fa77cd51804d724 parent 916b7c73db593510d5c38706be2f2888981747ee author Uwe Kleine-K=EF=BF=BDnig 12567= 57064 +0100 committer Jiri Kosina 1257780224 +0100 encoding ISO-8859-2 tree-wide: fix typos "couter" -> "counter" This patch was generated by git grep -E -i -l 'couter' | xargs -r perl -p -i -e 's/couter/counter= /' Signed-off-by: Uwe Kleine-K=EF=BF=BDnig Signed-off-by: Jiri Kosina So the remaining question is: Does the encoding specified in the encoding "header" also apply to the other headers? If yes[1] then there's a bug in git-shortlog ~/gsrc/linux-2.6$ git shortlog linus/master..trivial/for-next | grep U= we Uwe Kleine-K=EF=BF=BDnig (5): (with linus/master =3D 799dd75b1a8380a967c929a4551895788c374b31, trivial/for-next =3D 4030ec040a0e21fe9953da70eaa59ee7b4f2297b). =20 Best regards Uwe [1] git log linus/master..trivial/for-next looks OK, so I suspect it does apply. --=20 Pengutronix e.K. | Uwe Kleine-K=C3=B6nig = | Industrial Linux Solutions | http://www.pengutronix.= de/ |