Re: [PATCH 1/2] btrfs-progs: multidevice support for check_mounted

From: Karel Zak <kzak@redhat.com>
To: Andi Drebes <lists-receive@programmierforen.de>
Cc: linux-btrfs@vger.kernel.org, Chris Mason <chris.mason@oracle.com>,
	"Yan, Zheng" <yanzheng@21cn.com>
Subject: Re: [PATCH 1/2] btrfs-progs: multidevice support for check_mounted
Date: Sat, 21 Nov 2009 21:21:10 +0100	[thread overview]
Message-ID: <20091121202109.GD16301@nb.net.home> (raw)
In-Reply-To: <200911211538.38351.lists-receive@programmierforen.de>

On Sat, Nov 21, 2009 at 03:38:38PM +0100, Andi Drebes wrote:
> +
> +/* Checks if an mntentry represents a pseudo FS */
> +int is_pseudo_fs(const struct mntent* mnt)
> +{
> +	struct stat st_buf;
> +
> +	if(stat(mnt->mnt_fsname, &st_buf) < 0) {
> +		if(errno == ENOENT)
> +			return 1;
> +		else
> +			return -errno;
> +	}
> +
> +	return 0;
> +}

 This is bad idea. The mnt_fsname field could be an arbitrary string
 include valid paths.

        # grep sysfs /proc/mounts 
        /sys /sys sysfs rw,relatime 0 0

 Karel

-- 
 Karel Zak  <kzak@redhat.com>