From: Ben Dooks <ben@simtec.co.uk>
To: krzysztof.h1@wp.p, akpm@linux-foundation.org
Cc: lethal@linux-sh.org, dilinger@debian.org,
linux-fbdev-devel@lists.sourceforge.net,
Simtec Linux Team <linux@simtec.co.uk>
Subject: [PATCH 2/4] SM501: Fix missing uses of resource_size()
Date: Mon, 23 Nov 2009 16:01:26 +0000 [thread overview]
Message-ID: <20091123160144.936773910@fluff.org.uk> (raw)
In-Reply-To: 20091123160124.403392586@fluff.org.uk
[-- Attachment #1: simtec/ready/sm501-use-resource-size.patch --]
[-- Type: text/plain, Size: 2580 bytes --]
There are several places in the SM501 fb driver that could do with using
resource_size() to calculate the size of a resource.
Also fix a bug where request_mem_region() is being passed one too few
bytes when requesting the register memory region, which was causing
the following in /proc/iomem:
13e80000-13e8ffff : sm501-fb.0
13e80000-13e8fffe : sm501-fb
fixed, this reads:
13e80000-13e8ffff : sm501-fb.0
13e80000-13e8ffff : sm501-fb
Signed-off-by: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: Simtec Linux Team <linux@simtec.co.uk>
---
drivers/video/sm501fb.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Index: b/drivers/video/sm501fb.c
===================================================================
--- a/drivers/video/sm501fb.c 2009-09-09 23:13:59.000000000 +0100
+++ b/drivers/video/sm501fb.c 2009-11-10 19:31:25.000000000 +0000
@@ -1338,7 +1338,7 @@ static int sm501fb_start(struct sm501fb_
}
info->regs_res = request_mem_region(res->start,
- res->end - res->start,
+ resource_size(res),
pdev->name);
if (info->regs_res == NULL) {
@@ -1347,7 +1347,7 @@ static int sm501fb_start(struct sm501fb_
goto err_release;
}
- info->regs = ioremap(res->start, (res->end - res->start)+1);
+ info->regs = ioremap(res->start, resource_size(res));
if (info->regs == NULL) {
dev_err(dev, "cannot remap registers\n");
ret = -ENXIO;
@@ -1363,7 +1363,7 @@ static int sm501fb_start(struct sm501fb_
}
info->fbmem_res = request_mem_region(res->start,
- (res->end - res->start)+1,
+ resource_size(res),
pdev->name);
if (info->fbmem_res == NULL) {
dev_err(dev, "cannot claim framebuffer\n");
@@ -1371,13 +1371,13 @@ static int sm501fb_start(struct sm501fb_
goto err_regs_map;
}
- info->fbmem = ioremap(res->start, (res->end - res->start)+1);
+ info->fbmem = ioremap(res->start, resource_size(res));
if (info->fbmem == NULL) {
dev_err(dev, "cannot remap framebuffer\n");
goto err_mem_res;
}
- info->fbmem_len = (res->end - res->start)+1;
+ info->fbmem_len = resource_size(res);
/* clear framebuffer memory - avoids garbage data on unused fb */
memset(info->fbmem, 0, info->fbmem_len);
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
next prev parent reply other threads:[~2009-11-23 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091123160124.403392586@fluff.org.uk>
2009-11-23 16:01 ` [PATCH 1/4] FRAMEBUFFER: Fix cfbfillrect for non-zero colours Ben Dooks
2009-11-23 16:01 ` Ben Dooks [this message]
2009-11-23 16:01 ` [PATCH 3/4] SM501: Fix use of old <asm/io.h> instead of <linux/io.h> Ben Dooks
2009-11-23 16:01 ` [PATCH 4/4] SM501: Implement acceleration features Ben Dooks
2009-11-23 20:40 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091123160144.936773910@fluff.org.uk \
--to=ben@simtec.co.uk \
--cc=akpm@linux-foundation.org \
--cc=dilinger@debian.org \
--cc=krzysztof.h1@wp.p \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.