All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] pata_hpt{37x|3x2n}: fix timing register masks
Date: Tue, 24 Nov 2009 21:20:06 +0000	[thread overview]
Message-ID: <20091124212006.4730aacf@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200911242315.52826.sshtylyov@ru.mvista.com>

On Wed, 25 Nov 2009 00:15:52 +0400
Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:

> These drivers inherited from the older 'hpt366' IDE driver the buggy timing
> register masks in their set_piomode() metods. As a result, too low command
> cycle active time is programmed for slow PIO modes.  Quite fortunately, it's
> later "fixed up" by the set_dmamode() methods which also "helpfully" reprogram
> the command timings, usually to PIO mode 4.
> 
> However, the drivers added some breakage of their own too:  the bit that they
> set/clear to control the FIFO is wrong -- it's actually the MSB of the command
> cycle setup time; setting it in DMA mode is also wrong as this bit is only for
> PIO actually...
> 
> Fix all this and bump the drivers' versions, accounting for recenjt patches
> that forgot to do it...
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

Acked-by: Alan Cox <alan@linux.intel.com>

  reply	other threads:[~2009-11-24 21:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24 20:15 [PATCH] pata_hpt{37x|3x2n}: fix timing register masks Sergei Shtylyov
2009-11-24 21:20 ` Alan Cox [this message]
2009-11-26 20:51   ` Bartlomiej Zolnierkiewicz
2009-11-26 21:18     ` Sergei Shtylyov
2009-11-26 21:42       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091124212006.4730aacf@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=sshtylyov@ru.mvista.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.