From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934168AbZKXWXd (ORCPT ); Tue, 24 Nov 2009 17:23:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933799AbZKXWXc (ORCPT ); Tue, 24 Nov 2009 17:23:32 -0500 Received: from mail-gx0-f226.google.com ([209.85.217.226]:64562 "EHLO mail-gx0-f226.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933798AbZKXWXb (ORCPT ); Tue, 24 Nov 2009 17:23:31 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=YqEtf6iVU49KnTieW418fcIZ+8dexrj5m38Ayg9lxs3xzRRnR6REqfC56TD4AIBL8V NLZJ3F3lFtgvN8v6+HYS0sY6P+gIV47kZoGHhMHfzSfGjry2ZhTimm6hPrbD7X7pyquU Na3C3DSP8CB9mnrFkXLIapwtpQ5elQAm/mbnE= Date: Tue, 24 Nov 2009 17:23:34 -0500 From: tmhikaru@gmail.com To: tmhikaru@gmail.com Cc: Jan Kara , Alan Stern , Boaz Harrosh , Kernel development list , USB list , Jens Axboe , SCSI development list , linux-ext4@vger.kernel.org Subject: Re: Weird I/O errors with USB hard drive not remounting filesystem readonly Message-ID: <20091124222334.GB20245@roll> References: <20091124195607.GC16662@quack.suse.cz> <20091124203944.GD16662@quack.suse.cz> <20091124215044.GA20245@roll> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091124215044.GA20245@roll> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2009 at 04:50:44PM -0500, tmhikaru@gmail.com wrote: > On Tue, Nov 24, 2009 at 09:39:44PM +0100, Jan Kara wrote: > > On Tue 24-11-09 15:13:01, Alan Stern wrote: > > > On Tue, 24 Nov 2009, Jan Kara wrote: > > > > > > > After digging in block layer code, it's as we suspected: > > > > In case of host error DID_ERROR (which is our case), scsi request is > > > > retried iff it is not a FAILFAST request which is set if bio is doing > > > > readahead... So this is explained and everything behaves as it should. > > > > Thanks everybody involved :). > > > > > > Okay, very good. There remains the question of the disturbing error > > > messages in the system log. Should they be supressed for FAILFAST > > > requests? > > I think it's useful they are there because ultimately, something really > > went wrong and you should better investigate. BTW, "end_request: I/O error" > > messages are in the log even for requests where we retried and succeeded... > > > > Honza > > While I agree it is useful information, I think that if the error messages > are going to be printed, you should *also* print that this is a NON FATAL > error and that it's going to be retried. It'd help diagnosing the path it's > following through the failure code IMHO as well as not making users > completely freak out like I did in my case. It is *not* particularly obvious > given the message printed to syslog what is going wrong or why. > > Just my opinion, > Tim McGrath I should have asked since I'm here at the moment - do you need any more information out of the buggy USB enclosure at the moment, or can I work on trying to fix/replace it now? Tim McGrath