[U-Boot] [PATCH v2] mkconfig: deny messed up ARCH definition

[U-Boot] [PATCH v2] mkconfig: deny messed up ARCH definition

[Nishanth Menon]

Refuse to setup a platform if the command line ARCH= is not the same
as the one required for the board. This prevents any user with
prehistoric aliases from messing up their builds.

Reported in thread:
http://old.nabble.com/-U-Boot--Build-breaks-on-some-OMAP3-configs-to26132721.html

Inputs from: Mike Frysinger and Wolfgang Denk:
http://lists.denx.de/pipermail/u-boot/2009-November/063642.html

Cc: Wolfgang Denk <wd@denx.de>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Anand Gadiyar <gadiyar@ti.com>
Cc: Dirk Behme <dirk.behme@googlemail.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
 mkconfig |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/mkconfig b/mkconfig
index 4c5675b..1075510 100755
--- a/mkconfig
+++ b/mkconfig
@@ -27,6 +27,11 @@ done
 [ $# -lt 4 ] && exit 1
 [ $# -gt 6 ] && exit 1
 
+if [ "${ARCH}" -a "${ARCH}" != "$2" ]; then
+	echo "Failed: \$ARCH=${ARCH}, should be '$2' for ${BOARD_NAME}" 1>&2
+	exit 1
+fi
+
 echo "Configuring for ${BOARD_NAME} board..."
 
 #
-- 
1.6.3.3

[U-Boot] [PATCH v2] mkconfig: deny messed up ARCH definition

[Wolfgang Denk]

Dear Nishanth Menon,

In message <1257176418-11624-1-git-send-email-nm@ti.com> you wrote:
> Refuse to setup a platform if the command line ARCH= is not the same
> as the one required for the board. This prevents any user with
> prehistoric aliases from messing up their builds.
> 
> Reported in thread:
> http://old.nabble.com/-U-Boot--Build-breaks-on-some-OMAP3-configs-to26132721.html
> 
> Inputs from: Mike Frysinger and Wolfgang Denk:
> http://lists.denx.de/pipermail/u-boot/2009-November/063642.html
> 
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Mike Frysinger <vapier@gentoo.org>
> Cc: Anand Gadiyar <gadiyar@ti.com>
> Cc: Dirk Behme <dirk.behme@googlemail.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  mkconfig |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q:  How do you tell if you're making  love  to  a  nurse,  a  school-
    teacher, or an airline stewardess?
A:  A nurse says: "This won't hurt  a  bit."  A  schoolteacher  says:
    "We're  going to have to do this over and over again until we get
    it right." An airline stewardess says: "Just hold this over  your
    mouth and nose, and breath normally."