From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NDGKI-00086V-7A
	for qemu-devel@nongnu.org; Wed, 25 Nov 2009 06:46:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NDGKC-00085f-Up
	for qemu-devel@nongnu.org; Wed, 25 Nov 2009 06:46:25 -0500
Received: from [199.232.76.173] (port=60849 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NDGKC-00085a-Jm
	for qemu-devel@nongnu.org; Wed, 25 Nov 2009 06:46:20 -0500
Received: from mx20.gnu.org ([199.232.41.8]:10025)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1NDGKC-0001SU-Be
	for qemu-devel@nongnu.org; Wed, 25 Nov 2009 06:46:20 -0500
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1NDGKA-0003fW-Ui
	for qemu-devel@nongnu.org; Wed, 25 Nov 2009 06:46:19 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 06/13] Add support for S390x system emulation
Date: Wed, 25 Nov 2009 11:46:14 +0000
References: <1259083781-14642-1-git-send-email-agraf@suse.de>
	<1259083781-14642-7-git-send-email-agraf@suse.de>
In-Reply-To: <1259083781-14642-7-git-send-email-agraf@suse.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <200911251146.14502.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Carsten Otte <cotte@de.ibm.com>, Alexander Graf <agraf@suse.de>, Aurelien Jarno <aurelien@aurel32.net>

> --- a/target-s390x/cpu.h
> +++ b/target-s390x/cpu.h
> @@ -30,8 +30,7 @@
> 
>  #include "softfloat.h"
> 
> -#define NB_MMU_MODES 2 // guess
> -#define MMU_USER_IDX 0 // guess
> +#define NB_MMU_MODES 2

The fact that you're modifying a file you added earlier in the same patch 
series gives me very little confidence...

Paul